From 80ad1a17df5f7d06b7b6a46bac54ddc7ee1b26d3 Mon Sep 17 00:00:00 2001
From: Rick Elrod <rick@elrod.me>
Date: Mon, 10 Aug 2020 00:34:34 -0500
Subject: [PATCH] Remove incidental_lvg target (#71174)
Change:
- This no longer has any incidental coverage.
Test Plan:
- Coverage report
Signed-off-by: Rick Elrod <rick@elrod.me>
---
.../targets/incidental_lvg/aliases | 6 ----
.../targets/incidental_lvg/meta/main.yml | 2 --
.../targets/incidental_lvg/tasks/main.yml | 15 ---------
.../targets/incidental_lvg/tasks/setup.yml | 13 --------
.../targets/incidental_lvg/tasks/teardown.yml | 17 ----------
.../incidental_lvg/tasks/test_grow_reduce.yml | 33 -------------------
.../tasks/test_indempotency.yml | 15 ---------
7 files changed, 101 deletions(-)
delete mode 100644 test/integration/targets/incidental_lvg/aliases
delete mode 100644 test/integration/targets/incidental_lvg/meta/main.yml
delete mode 100644 test/integration/targets/incidental_lvg/tasks/main.yml
delete mode 100644 test/integration/targets/incidental_lvg/tasks/setup.yml
delete mode 100644 test/integration/targets/incidental_lvg/tasks/teardown.yml
delete mode 100644 test/integration/targets/incidental_lvg/tasks/test_grow_reduce.yml
delete mode 100644 test/integration/targets/incidental_lvg/tasks/test_indempotency.yml
diff --git a/test/integration/targets/incidental_lvg/aliases b/test/integration/targets/incidental_lvg/aliases
deleted file mode 100644
index d5baa06d53d..00000000000
--- a/test/integration/targets/incidental_lvg/aliases
+++ /dev/null
@@ -1,6 +0,0 @@
-destructive
-needs/privileged
-shippable/posix/incidental
-skip/aix
-skip/freebsd
-skip/osx
diff --git a/test/integration/targets/incidental_lvg/meta/main.yml b/test/integration/targets/incidental_lvg/meta/main.yml
deleted file mode 100644
index 1810d4bec98..00000000000
--- a/test/integration/targets/incidental_lvg/meta/main.yml
+++ /dev/null
@@ -1,2 +0,0 @@
-dependencies:
- - setup_remote_tmp_dir
diff --git a/test/integration/targets/incidental_lvg/tasks/main.yml b/test/integration/targets/incidental_lvg/tasks/main.yml
deleted file mode 100644
index a57f591bf02..00000000000
--- a/test/integration/targets/incidental_lvg/tasks/main.yml
+++ /dev/null
@@ -1,15 +0,0 @@
-- name: Install required packages (Linux)
- package:
- name: lvm2
- state: present
- when: ansible_system == 'Linux'
-
-- name: Test lvg module
- block:
- - import_tasks: setup.yml
-
- - import_tasks: test_indempotency.yml
-
- - import_tasks: test_grow_reduce.yml
- always:
- - import_tasks: teardown.yml
diff --git a/test/integration/targets/incidental_lvg/tasks/setup.yml b/test/integration/targets/incidental_lvg/tasks/setup.yml
deleted file mode 100644
index e63c2d641e3..00000000000
--- a/test/integration/targets/incidental_lvg/tasks/setup.yml
+++ /dev/null
@@ -1,13 +0,0 @@
-- name: "Create files to use as a disk devices"
- command: "dd if=/dev/zero of={{ remote_tmp_dir }}/img{{ item }} bs=1M count=10"
- with_sequence: 'count=2'
-
-- name: "Create loop device for file"
- command: "losetup --show -f {{ remote_tmp_dir }}/img{{ item }}"
- with_sequence: 'count=2'
- register: loop_devices
-
-- name: "Affect name on disk to work on"
- set_fact:
- loop_device1: "{{ loop_devices.results[0] }}"
- loop_device2: "{{ loop_devices.results[1] }}"
diff --git a/test/integration/targets/incidental_lvg/tasks/teardown.yml b/test/integration/targets/incidental_lvg/tasks/teardown.yml
deleted file mode 100644
index ed662f1e1f5..00000000000
--- a/test/integration/targets/incidental_lvg/tasks/teardown.yml
+++ /dev/null
@@ -1,17 +0,0 @@
-- name: Remove test volume group
- lvg:
- vg: testvg
- state: absent
-
-- name: Detach loop device
- command: "losetup -d {{ item.stdout }}"
- loop: "{{ loop_devices.results|default([]) }}"
- when:
- - item.stdout is defined
- - item.stdout is match("/dev/.*")
-
-- name: Remove device files
- file:
- path: "{{ remote_tmp_dir }}/img{{ item }}"
- state: absent
- with_sequence: 'count={{ loop_devices.results|length }}'
diff --git a/test/integration/targets/incidental_lvg/tasks/test_grow_reduce.yml b/test/integration/targets/incidental_lvg/tasks/test_grow_reduce.yml
deleted file mode 100644
index 1e988045383..00000000000
--- a/test/integration/targets/incidental_lvg/tasks/test_grow_reduce.yml
+++ /dev/null
@@ -1,33 +0,0 @@
-- name: "Create volume group on first disk"
- lvg:
- vg: testvg
- pvs: "{{ loop_device1.stdout }}"
-
-- name: "get lvm facts"
- setup:
-
-- debug: var=ansible_lvm
-
-- name: "Assert the testvg span only on first disk"
- assert:
- that:
- - ansible_lvm.pvs[loop_device1.stdout].vg == "testvg"
- - 'loop_device2.stdout not in ansible_lvm.pvs or
- ansible_lvm.pvs[loop_device2.stdout].vg == ""'
-
-- name: "Extend to second disk AND reduce from the first disk"
- lvg:
- vg: testvg
- pvs: "{{ loop_device2.stdout }}"
-
-- name: "get lvm facts"
- setup:
-
-- debug: var=ansible_lvm
-
-- name: "Assert the testvg span only on first disk"
- assert:
- that:
- - 'loop_device1.stdout not in ansible_lvm.pvs or
- ansible_lvm.pvs[loop_device1.stdout].vg == ""'
- - ansible_lvm.pvs[loop_device2.stdout].vg == "testvg"
diff --git a/test/integration/targets/incidental_lvg/tasks/test_indempotency.yml b/test/integration/targets/incidental_lvg/tasks/test_indempotency.yml
deleted file mode 100644
index 5007e56a5b4..00000000000
--- a/test/integration/targets/incidental_lvg/tasks/test_indempotency.yml
+++ /dev/null
@@ -1,15 +0,0 @@
-- name: Create volume group on disk device
- lvg:
- vg: testvg
- pvs: "{{ loop_device1.stdout }}"
-
-- name: Create the volume group again to verify idempotence
- lvg:
- vg: testvg
- pvs: "{{ loop_device1.stdout }}"
- register: repeat_vg_create
-
-- name: Do all assertions to verify expected results
- assert:
- that:
- - repeat_vg_create is not changed