Ensure task from the worker is finalized/squashed (#73881)

* Ensure task from the worker is finalized/squashed. Fixes #57399. Fixes #49942
This commit is contained in:
Matt Martz 2021-03-16 14:09:43 -05:00 committed by GitHub
parent a29fcfa995
commit 832631b888
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 32 additions and 0 deletions

View file

@ -0,0 +1,5 @@
bugfixes:
- Strategy - When building the task in the Strategy from the Worker,
ensure it is properly marked as finalized and squashed. Addresses an
issue with ``ansible_failed_task``.
(https://github.com/ansible/ansible/issues/57399)

View file

@ -545,6 +545,13 @@ class FieldAttributeBase(with_metaclass(BaseMeta, object)):
else: else:
setattr(self, attr, value) setattr(self, attr, value)
# from_attrs is only used to create a finalized task
# from attrs from the Worker/TaskExecutor
# Those attrs are finalized and squashed in the TE
# and controller side use needs to reflect that
self._finalized = True
self._squashed = True
def serialize(self): def serialize(self):
''' '''
Serializes the object derived from the base object into Serializes the object derived from the base object into

View file

@ -0,0 +1,17 @@
- hosts: localhost
gather_facts: false
tasks:
- block:
- include_role:
name: '{{ item }}'
loop:
- fail
rescue:
- debug:
msg: "{{ ansible_failed_task.name }}"
- assert:
that:
- ansible_failed_task.name == "Fail"
- ansible_failed_task.action == "fail"
- ansible_failed_task.parent is not defined

View file

@ -0,0 +1,3 @@
- name: Fail
fail:
msg: fail