From 86b24498b79be6d1432aa293c08c4c76bdbe238e Mon Sep 17 00:00:00 2001 From: Rick Elrod Date: Fri, 17 Jul 2020 14:52:45 -0500 Subject: [PATCH] Add intentional coverage for an async_wrapper case (#70593) (#70630) * Add intentional coverage for an async_wrapper case (#70593) Change: - Test async_wrapper when the module it runs has stderr output Test Plan: - CI - Looked at coverage report and saw green for a few lines that weren't previously green. Signed-off-by: Rick Elrod * sigh Signed-off-by: Rick Elrod --- test/integration/targets/async/library/async_test.py | 6 ++++++ test/integration/targets/async/tasks/main.yml | 12 ++++++++++++ test/sanity/ignore.txt | 2 -- 3 files changed, 18 insertions(+), 2 deletions(-) diff --git a/test/integration/targets/async/library/async_test.py b/test/integration/targets/async/library/async_test.py index 3098bc601cb..f89bd10e74c 100644 --- a/test/integration/targets/async/library/async_test.py +++ b/test/integration/targets/async/library/async_test.py @@ -1,3 +1,6 @@ +from __future__ import (absolute_import, division, print_function) +__metaclass__ = type + import json import sys @@ -33,6 +36,9 @@ def main(): if 'exception' in fail_mode: raise Exception('failing via exception') + if 'stderr' in fail_mode: + print('printed to stderr', file=sys.stderr) + module.exit_json(**result) finally: diff --git a/test/integration/targets/async/tasks/main.yml b/test/integration/targets/async/tasks/main.yml index f84ad9b3f31..b1925d25599 100644 --- a/test/integration/targets/async/tasks/main.yml +++ b/test/integration/targets/async/tasks/main.yml @@ -165,6 +165,18 @@ - async_result is successful - async_result.warnings[0] is search('trailing junk after module output') +- name: test stderr handling + async_test: + fail_mode: stderr + async: 30 + poll: 1 + register: async_result + ignore_errors: true + +- assert: + that: + - async_result.stderr == "printed to stderr\n" + # NOTE: This should report a warning that cannot be tested - name: test async properties on non-async task command: sleep 1 diff --git a/test/sanity/ignore.txt b/test/sanity/ignore.txt index 53dafcd1361..1ca04c5253b 100644 --- a/test/sanity/ignore.txt +++ b/test/sanity/ignore.txt @@ -217,8 +217,6 @@ test/integration/targets/ansible-test/ansible_collections/ns/col/tests/unit/plug test/integration/targets/ansible-test-docker/ansible_collections/ns/col/plugins/modules/hello.py pylint:relative-beyond-top-level test/integration/targets/ansible-test-docker/ansible_collections/ns/col/tests/unit/plugins/module_utils/test_my_util.py pylint:relative-beyond-top-level test/integration/targets/ansible-test-docker/ansible_collections/ns/col/tests/unit/plugins/modules/test_hello.py pylint:relative-beyond-top-level -test/integration/targets/async/library/async_test.py future-import-boilerplate -test/integration/targets/async/library/async_test.py metaclass-boilerplate test/integration/targets/async_fail/library/async_test.py future-import-boilerplate test/integration/targets/async_fail/library/async_test.py metaclass-boilerplate test/integration/targets/collections_plugin_namespace/collection_root/ansible_collections/my_ns/my_col/plugins/lookup/lookup_no_future_boilerplate.py future-import-boilerplate