Using Get-AnsibleParam

conflict

typo

lib/ansible/modules/extras/windows/win_uri.ps1

@@ -1,7 +1,7 @@
 #!powershell
 # This file is part of Ansible
 #
-# Copyright 2015, Corwin Brown <blakfeld@gmail.com>
+# Copyright 2015, Corwin Brown <corwin.brown@maxpoint.com>
 #
 # Ansible is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -27,32 +27,22 @@ $result = New-Object psobject @{
 
 # Build Arguments
 $webrequest_opts = @{}
-if (Get-Member -InputObject $params -Name url) {
-    $url = $params.url.ToString()
-    $webrequest_opts.Uri = $url
-} else {
-    Fail-Json $result "Missing required argument: url"
-}
 
-if (Get-Member -InputObject $params -Name method) {
+$url = Get-AnsibleParam -obj $params -name "url" -failifempty $true
-    $method = $params.method.ToString()
+$method = Get-AnsibleParam -obj $params "method" -default "GET"
-    $webrequest_opts.Method = $method
+$content_type = Get-AnsibleParam -obj $params -name "content_type"
-}
+$body = Get-AnsibleParam -obj $params -name "body"
 
-if (Get-Member -InputObject $params -Name content_type) {
+$webrequest_opts.Uri = $url
-    $content_type = $params.method.content_type.ToString()
+Set-Attr $result.win_uri "url" $url
-    $webrequest_opts.ContentType = $content_type
-}
 
-if (Get-Member -InputObject $params -Name body) {
+@webrequest_opts.Method = $method
-    $body = $params.method.body.ToString()
+Set-Attr $result.win_uri "method" $method
-    $webrequest_opts.Body = $body
-}
 
-if (Get-Member -InputObject $params -Name headers) {
+@webrequest_opts.content_type = $content_type
-    $headers = $params.headers
+Set-Attr $result.content_type "content_type" $content_type
-    Set-Attr $result.win_uri "headers" $headers
 
+if ($headers -ne $null) {
     $req_headers = @{}
     ForEach ($header in $headers.psobject.properties) {
         $req_headers.Add($header.Name, $header.Value)

lib/ansible/modules/extras/windows/win_uri.py

@@ -24,7 +24,7 @@
 DOCUMENTATION = """
 ---
 module: win_uri
-version_added: ""
+version_added: "2.0"
 short_description: Interacts with webservices.
 description:
   - Interacts with HTTP and HTTPS services.
@@ -32,10 +32,12 @@ options:
   url:
     description:
       - HTTP or HTTPS URL in the form of (http|https)://host.domain:port/path
+    required: true
   method:
     description:
       - The HTTP Method of the request or response.
     default: GET
+    required: false
     choices:
       - GET
       - POST
@@ -53,13 +55,17 @@ options:
   body:
     description:
       - The body of the HTTP request/response to the web service.
+    required: false
+    default: None
   headers:
     description:
       - Key Value pairs for headers. Example "Host: www.somesite.com"
-author: Corwin Brown
+    required: false
+    default: None
+author: Corwin Brown (@blakfeld)
 """
 
-Examples= """
+Examples = """
 # Send a GET request and store the output:
 ---
 - name: Perform a GET and Store Output
@@ -90,4 +96,19 @@ Examples= """
     url: http://www.somesite.com
     method: POST
     body: "{ 'some': 'json' }"
+
+# Check if a file is available on a webserver
+---
+- name: Ensure Build is Available on Fileserver
+  when: ensure_build
+  win_uri:
+    url: "http://www.somesite.com"
+    method: HEAD
+    headers:
+      test: one
+      another: two
+  register: build_check_output
+  until: build_check_output.StatusCode == 200
+  retries: 30
+  delay: 10
 """