cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fortinet's new module for fortios_system_switch_interface (#60972)

Browse source
This commit is contained in:
Miguel Angel Muñoz González 2019-08-22 10:53:16 +02:00 committed by Rohit
parent da7ed1d8a6
commit 8b882be084
2 changed files with 655 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

396
lib/ansible/modules/network/fortios/fortios_system_switch_interface.py Normal file
View file

@ -0,0 +1,396 @@
#!/usr/bin/python
from __future__ import (absolute_import, division, print_function)
# Copyright 2019 Fortinet, Inc.
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <https://www.gnu.org/licenses/>.
__metaclass__ = type
ANSIBLE_METADATA = {'status': ['preview'],
'supported_by': 'community',
'metadata_version': '1.1'}
DOCUMENTATION = '''
---
module: fortios_system_switch_interface
short_description: Configure software switch interfaces by grouping physical and WiFi interfaces in Fortinet's FortiOS and FortiGate.
description:
- This module is able to configure a FortiGate or FortiOS (FOS) device by allowing the
user to set and modify system feature and switch_interface category.
Examples include all parameters and values need to be adjusted to datasources before usage.
Tested with FOS v6.0.5
version_added: "2.9"
author:
- Miguel Angel Munoz (@mamunozgonzalez)
- Nicolas Thomas (@thomnico)
notes:
- Requires fortiosapi library developed by Fortinet
- Run as a local_action in your playbook
requirements:
- fortiosapi>=0.9.8
options:
host:
description:
- FortiOS or FortiGate IP address.
type: str
required: false
username:
description:
- FortiOS or FortiGate username.
type: str
required: false
password:
description:
- FortiOS or FortiGate password.
type: str
default: ""
vdom:
description:
- Virtual domain, among those defined previously. A vdom is a
virtual instance of the FortiGate that can be configured and
used as a different unit.
type: str
default: root
https:
description:
- Indicates if the requests towards FortiGate must use HTTPS protocol.
type: bool
default: true
ssl_verify:
description:
- Ensures FortiGate certificate must be verified by a proper CA.
type: bool
default: true
state:
description:
- Indicates whether to create or remove the object.
type: str
required: true
choices:
- present
- absent
system_switch_interface:
description:
- Configure software switch interfaces by grouping physical and WiFi interfaces.
default: null
type: dict
suboptions:
intra_switch_policy:
description:
- Allow any traffic between switch interfaces or require firewall policies to allow traffic between switch interfaces.
type: str
choices:
- implicit
- explicit
member:
description:
- Names of the interfaces that belong to the virtual switch.
type: list
suboptions:
interface_name:
description:
- Physical interface name. Source system.interface.name.
type: str
name:
description:
- Interface name (name cannot be in use by any other interfaces, VLANs, or inter-VDOM links).
required: true
type: str
span:
description:
- Enable/disable port spanning. Port spanning echoes traffic received by the software switch to the span destination port.
type: str
choices:
- disable
- enable
span_dest_port:
description:
- SPAN destination port name. All traffic on the SPAN source ports is echoed to the SPAN destination port. Source system.interface.name.
type: str
span_direction:
description:
- "The direction in which the SPAN port operates, either: rx, tx, or both."
type: str
choices:
- rx
- tx
- both
span_source_port:
description:
- Physical interface name. Port spanning echoes all traffic on the SPAN source ports to the SPAN destination port.
type: list
suboptions:
interface_name:
description:
- Physical interface name. Source system.interface.name.
type: str
type:
description:
- "Type of switch based on functionality: switch for normal functionality, or hub to duplicate packets to all port members."
type: str
choices:
- switch
- hub
vdom:
description:
- VDOM that the software switch belongs to. Source system.vdom.name.
type: str
'''
EXAMPLES = '''
- hosts: localhost
vars:
host: "192.168.122.40"
username: "admin"
password: ""
vdom: "root"
ssl_verify: "False"
tasks:
- name: Configure software switch interfaces by grouping physical and WiFi interfaces.
fortios_system_switch_interface:
host: "{{ host }}"
username: "{{ username }}"
password: "{{ password }}"
vdom: "{{ vdom }}"
https: "False"
state: "present"
system_switch_interface:
intra_switch_policy: "implicit"
member:
-
interface_name: "<your_own_value> (source system.interface.name)"
name: "default_name_6"
span: "disable"
span_dest_port: "<your_own_value> (source system.interface.name)"
span_direction: "rx"
span_source_port:
-
interface_name: "<your_own_value> (source system.interface.name)"
type: "switch"
vdom: "<your_own_value> (source system.vdom.name)"
'''
RETURN = '''
build:
description: Build number of the fortigate image
returned: always
type: str
sample: '1547'
http_method:
description: Last method used to provision the content into FortiGate
returned: always
type: str
sample: 'PUT'
http_status:
description: Last result given by FortiGate on last operation applied
returned: always
type: str
sample: "200"
mkey:
description: Master key (id) used in the last call to FortiGate
returned: success
type: str
sample: "id"
name:
description: Name of the table used to fulfill the request
returned: always
type: str
sample: "urlfilter"
path:
description: Path of the table used to fulfill the request
returned: always
type: str
sample: "webfilter"
revision:
description: Internal revision number
returned: always
type: str
sample: "17.0.2.10658"
serial:
description: Serial number of the unit
returned: always
type: str
sample: "FGVMEVYYQT3AB5352"
status:
description: Indication of the operation's result
returned: always
type: str
sample: "success"
vdom:
description: Virtual domain used
returned: always
type: str
sample: "root"
version:
description: Version of the FortiGate
returned: always
type: str
sample: "v5.6.3"
'''
from ansible.module_utils.basic import AnsibleModule
from ansible.module_utils.connection import Connection
from ansible.module_utils.network.fortios.fortios import FortiOSHandler
from ansible.module_utils.network.fortimanager.common import FAIL_SOCKET_MSG
def login(data, fos):
host = data['host']
username = data['username']
password = data['password']
ssl_verify = data['ssl_verify']
fos.debug('on')
if 'https' in data and not data['https']:
fos.https('off')
else:
fos.https('on')
fos.login(host, username, password, verify=ssl_verify)
def filter_system_switch_interface_data(json):
option_list = ['intra_switch_policy', 'member', 'name',
'span', 'span_dest_port', 'span_direction',
'span_source_port', 'type', 'vdom']
dictionary = {}
for attribute in option_list:
if attribute in json and json[attribute] is not None:
dictionary[attribute] = json[attribute]
return dictionary
def underscore_to_hyphen(data):
if isinstance(data, list):
for elem in data:
elem = underscore_to_hyphen(elem)
elif isinstance(data, dict):
new_data = {}
for k, v in data.items():
new_data[k.replace('_', '-')] = underscore_to_hyphen(v)
data = new_data
return data
def system_switch_interface(data, fos):
vdom = data['vdom']
state = data['state']
system_switch_interface_data = data['system_switch_interface']
filtered_data = underscore_to_hyphen(filter_system_switch_interface_data(system_switch_interface_data))
if state == "present":
return fos.set('system',
'switch-interface',
data=filtered_data,
vdom=vdom)
elif state == "absent":
return fos.delete('system',
'switch-interface',
mkey=filtered_data['name'],
vdom=vdom)
def is_successful_status(status):
return status['status'] == "success" or \
status['http_method'] == "DELETE" and status['http_status'] == 404
def fortios_system(data, fos):
if data['system_switch_interface']:
resp = system_switch_interface(data, fos)
return not is_successful_status(resp), \
resp['status'] == "success", \
resp
def main():
fields = {
"host": {"required": False, "type": "str"},
"username": {"required": False, "type": "str"},
"password": {"required": False, "type": "str", "default": "", "no_log": True},
"vdom": {"required": False, "type": "str", "default": "root"},
"https": {"required": False, "type": "bool", "default": True},
"ssl_verify": {"required": False, "type": "bool", "default": True},
"state": {"required": True, "type": "str",
"choices": ["present", "absent"]},
"system_switch_interface": {
"required": False, "type": "dict", "default": None,
"options": {
"intra_switch_policy": {"required": False, "type": "str",
"choices": ["implicit", "explicit"]},
"member": {"required": False, "type": "list",
"options": {
"interface_name": {"required": False, "type": "str"}
}},
"name": {"required": True, "type": "str"},
"span": {"required": False, "type": "str",
"choices": ["disable", "enable"]},
"span_dest_port": {"required": False, "type": "str"},
"span_direction": {"required": False, "type": "str",
"choices": ["rx", "tx", "both"]},
"span_source_port": {"required": False, "type": "list",
"options": {
"interface_name": {"required": False, "type": "str"}
}},
"type": {"required": False, "type": "str",
"choices": ["switch", "hub"]},
"vdom": {"required": False, "type": "str"}
}
}
}
module = AnsibleModule(argument_spec=fields,
supports_check_mode=False)
# legacy_mode refers to using fortiosapi instead of HTTPAPI
legacy_mode = 'host' in module.params and module.params['host'] is not None and \
'username' in module.params and module.params['username'] is not None and \
'password' in module.params and module.params['password'] is not None
if not legacy_mode:
if module._socket_path:
connection = Connection(module._socket_path)
fos = FortiOSHandler(connection)
is_error, has_changed, result = fortios_system(module.params, fos)
else:
module.fail_json(**FAIL_SOCKET_MSG)
else:
try:
from fortiosapi import FortiOSAPI
except ImportError:
module.fail_json(msg="fortiosapi module is required")
fos = FortiOSAPI()
login(module.params, fos)
is_error, has_changed, result = fortios_system(module.params, fos)
fos.logout()
if not is_error:
module.exit_json(changed=has_changed, meta=result)
else:
module.fail_json(msg="Error in repo", meta=result)
if __name__ == '__main__':
main()

259
test/units/modules/network/fortios/test_fortios_system_switch_interface.py Normal file
View file

@ -0,0 +1,259 @@
# Copyright 2019 Fortinet, Inc.
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Ansible. If not, see <https://www.gnu.org/licenses/>.
# Make coding more python3-ish
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
import os
import json
import pytest
from mock import ANY
from ansible.module_utils.network.fortios.fortios import FortiOSHandler
try:
from ansible.modules.network.fortios import fortios_system_switch_interface
except ImportError:
pytest.skip("Could not load required modules for testing", allow_module_level=True)
@pytest.fixture(autouse=True)
def connection_mock(mocker):
connection_class_mock = mocker.patch('ansible.modules.network.fortios.fortios_system_switch_interface.Connection')
return connection_class_mock
fos_instance = FortiOSHandler(connection_mock)
def test_system_switch_interface_creation(mocker):
schema_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.schema')
set_method_result = {'status': 'success', 'http_method': 'POST', 'http_status': 200}
set_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.set', return_value=set_method_result)
input_data = {
'username': 'admin',
'state': 'present',
'system_switch_interface': {
'intra_switch_policy': 'implicit',
'name': 'default_name_4',
'span': 'disable',
'span_dest_port': 'test_value_6',
'span_direction': 'rx',
'type': 'switch',
'vdom': 'test_value_9'
},
'vdom': 'root'}
is_error, changed, response = fortios_system_switch_interface.fortios_system(input_data, fos_instance)
expected_data = {
'intra-switch-policy': 'implicit',
'name': 'default_name_4',
'span': 'disable',
'span-dest-port': 'test_value_6',
'span-direction': 'rx',
'type': 'switch',
'vdom': 'test_value_9'
}
set_method_mock.assert_called_with('system', 'switch-interface', data=expected_data, vdom='root')
schema_method_mock.assert_not_called()
assert not is_error
assert changed
assert response['status'] == 'success'
assert response['http_status'] == 200
def test_system_switch_interface_creation_fails(mocker):
schema_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.schema')
set_method_result = {'status': 'error', 'http_method': 'POST', 'http_status': 500}
set_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.set', return_value=set_method_result)
input_data = {
'username': 'admin',
'state': 'present',
'system_switch_interface': {
'intra_switch_policy': 'implicit',
'name': 'default_name_4',
'span': 'disable',
'span_dest_port': 'test_value_6',
'span_direction': 'rx',
'type': 'switch',
'vdom': 'test_value_9'
},
'vdom': 'root'}
is_error, changed, response = fortios_system_switch_interface.fortios_system(input_data, fos_instance)
expected_data = {
'intra-switch-policy': 'implicit',
'name': 'default_name_4',
'span': 'disable',
'span-dest-port': 'test_value_6',
'span-direction': 'rx',
'type': 'switch',
'vdom': 'test_value_9'
}
set_method_mock.assert_called_with('system', 'switch-interface', data=expected_data, vdom='root')
schema_method_mock.assert_not_called()
assert is_error
assert not changed
assert response['status'] == 'error'
assert response['http_status'] == 500
def test_system_switch_interface_removal(mocker):
schema_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.schema')
delete_method_result = {'status': 'success', 'http_method': 'POST', 'http_status': 200}
delete_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.delete', return_value=delete_method_result)
input_data = {
'username': 'admin',
'state': 'absent',
'system_switch_interface': {
'intra_switch_policy': 'implicit',
'name': 'default_name_4',
'span': 'disable',
'span_dest_port': 'test_value_6',
'span_direction': 'rx',
'type': 'switch',
'vdom': 'test_value_9'
},
'vdom': 'root'}
is_error, changed, response = fortios_system_switch_interface.fortios_system(input_data, fos_instance)
delete_method_mock.assert_called_with('system', 'switch-interface', mkey=ANY, vdom='root')
schema_method_mock.assert_not_called()
assert not is_error
assert changed
assert response['status'] == 'success'
assert response['http_status'] == 200
def test_system_switch_interface_deletion_fails(mocker):
schema_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.schema')
delete_method_result = {'status': 'error', 'http_method': 'POST', 'http_status': 500}
delete_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.delete', return_value=delete_method_result)
input_data = {
'username': 'admin',
'state': 'absent',
'system_switch_interface': {
'intra_switch_policy': 'implicit',
'name': 'default_name_4',
'span': 'disable',
'span_dest_port': 'test_value_6',
'span_direction': 'rx',
'type': 'switch',
'vdom': 'test_value_9'
},
'vdom': 'root'}
is_error, changed, response = fortios_system_switch_interface.fortios_system(input_data, fos_instance)
delete_method_mock.assert_called_with('system', 'switch-interface', mkey=ANY, vdom='root')
schema_method_mock.assert_not_called()
assert is_error
assert not changed
assert response['status'] == 'error'
assert response['http_status'] == 500
def test_system_switch_interface_idempotent(mocker):
schema_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.schema')
set_method_result = {'status': 'error', 'http_method': 'DELETE', 'http_status': 404}
set_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.set', return_value=set_method_result)
input_data = {
'username': 'admin',
'state': 'present',
'system_switch_interface': {
'intra_switch_policy': 'implicit',
'name': 'default_name_4',
'span': 'disable',
'span_dest_port': 'test_value_6',
'span_direction': 'rx',
'type': 'switch',
'vdom': 'test_value_9'
},
'vdom': 'root'}
is_error, changed, response = fortios_system_switch_interface.fortios_system(input_data, fos_instance)
expected_data = {
'intra-switch-policy': 'implicit',
'name': 'default_name_4',
'span': 'disable',
'span-dest-port': 'test_value_6',
'span-direction': 'rx',
'type': 'switch',
'vdom': 'test_value_9'
}
set_method_mock.assert_called_with('system', 'switch-interface', data=expected_data, vdom='root')
schema_method_mock.assert_not_called()
assert not is_error
assert not changed
assert response['status'] == 'error'
assert response['http_status'] == 404
def test_system_switch_interface_filter_foreign_attributes(mocker):
schema_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.schema')
set_method_result = {'status': 'success', 'http_method': 'POST', 'http_status': 200}
set_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.set', return_value=set_method_result)
input_data = {
'username': 'admin',
'state': 'present',
'system_switch_interface': {
'random_attribute_not_valid': 'tag',
'intra_switch_policy': 'implicit',
'name': 'default_name_4',
'span': 'disable',
'span_dest_port': 'test_value_6',
'span_direction': 'rx',
'type': 'switch',
'vdom': 'test_value_9'
},
'vdom': 'root'}
is_error, changed, response = fortios_system_switch_interface.fortios_system(input_data, fos_instance)
expected_data = {
'intra-switch-policy': 'implicit',
'name': 'default_name_4',
'span': 'disable',
'span-dest-port': 'test_value_6',
'span-direction': 'rx',
'type': 'switch',
'vdom': 'test_value_9'
}
set_method_mock.assert_called_with('system', 'switch-interface', data=expected_data, vdom='root')
schema_method_mock.assert_not_called()
assert not is_error
assert changed
assert response['status'] == 'success'
assert response['http_status'] == 200