cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Move existing check for root before we make expensive network calls

Browse source
This commit is contained in:
Toshio Kuratomi 2015-11-01 12:58:20 -08:00 committed by Matt Clay
parent 8e255afbec
commit 8c8c63110e
1 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
lib/ansible/modules/extras/packaging/os/dnf.py
View file

@ -241,9 +241,6 @@ def _mark_package_install(module, base, pkg_spec):
def ensure(module, base, state, names): def ensure(module, base, state, names):
if not util.am_i_root():
module.fail_json(msg="This command has to be run under the root user.")
if names == ['*'] and state == 'latest': if names == ['*'] and state == 'latest':
base.upgrade_all() base.upgrade_all()
else: else:
@ -337,12 +334,20 @@ def main():
mutually_exclusive=[['name', 'list']], mutually_exclusive=[['name', 'list']],
supports_check_mode=True) supports_check_mode=True)
params = module.params params = module.params
if params['list']:
base = _base( base = _base(
module, params['conf_file'], params['disable_gpg_check'], module, params['conf_file'], params['disable_gpg_check'],
params['disablerepo'], params['enablerepo']) params['disablerepo'], params['enablerepo'])
if params['list']:
list_items(module, base, params['list']) list_items(module, base, params['list'])
else: else:
# Note: base takes a long time to run so we want to check for failure
# before running it.
if not util.am_i_root():
module.fail_json(msg="This command has to be run under the root user.")
base = _base(
module, params['conf_file'], params['disable_gpg_check'],
params['disablerepo'], params['enablerepo'])
ensure(module, base, params['state'], params['name']) ensure(module, base, params['state'], params['name'])