cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Remove a unneeded use of use_unsafe_shell

Browse source 
Since use_unsafe_shell is suspicious from a security point
of view (or it wouldn't be unsafe), the less we have, the less
code we have to toroughly inspect for a security audit.
This commit is contained in:
Michael Scherer 2015-12-10 00:00:19 +01:00
parent 0b5555b62c
commit 8ccfdb874e
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
system/hostname.py
View file

@ -260,8 +260,8 @@ class SystemdStrategy(GenericStrategy):
(rc, out, err)) (rc, out, err))
def get_permanent_hostname(self): def get_permanent_hostname(self):
cmd = 'hostnamectl --static status' cmd = ['hostnamectl', '--static', 'status']
rc, out, err = self.module.run_command(cmd, use_unsafe_shell=True) rc, out, err = self.module.run_command(cmd)
if rc != 0: if rc != 0:
self.module.fail_json(msg="Command failed rc=%d, out=%s, err=%s" % self.module.fail_json(msg="Command failed rc=%d, out=%s, err=%s" %
(rc, out, err)) (rc, out, err))