cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Use return codes > 255 for Ansible-specific errors.

Browse source 
I had made and pushed this change after you already pulled the request.

@dhozac indicated that it would probably be better to use return codes > 255 for anything related to Ansible itself. Which makes sens :)
This commit is contained in:
Dag Wieers 2012-10-30 10:36:11 +01:00
parent 9a12873166
commit 8d4f9febd8
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
library/command
View file

@ -84,7 +84,7 @@ def main():
args = module.params['args'] args = module.params['args']
if args.strip() == '': if args.strip() == '':
module.fail_json(rc=255, msg="no command given") module.fail_json(rc=256, msg="no command given")
if chdir: if chdir:
os.chdir(os.path.expanduser(chdir)) os.chdir(os.path.expanduser(chdir))
@ -99,7 +99,7 @@ def main():
except (OSError, IOError), e: except (OSError, IOError), e:
module.fail_json(rc=e.errno, msg=str(e), cmd=args) module.fail_json(rc=e.errno, msg=str(e), cmd=args)
except: except:
module.fail_json(rc=254, msg=traceback.format_exc(), cmd=args) module.fail_json(rc=257, msg=traceback.format_exc(), cmd=args)
endd = datetime.datetime.now() endd = datetime.datetime.now()
delta = endd - startd delta = endd - startd
@ -178,9 +178,9 @@ class CommandModule(AnsibleModule):
elif m.group(2) == "chdir": elif m.group(2) == "chdir":
v = os.path.expanduser(v) v = os.path.expanduser(v)
if not (os.path.exists(v) and os.path.isdir(v)): if not (os.path.exists(v) and os.path.isdir(v)):
self.fail_json(rc=253, msg="cannot change to directory '%s': path does not exist" % v) self.fail_json(rc=258, msg="cannot change to directory '%s': path does not exist" % v)
elif v[0] != '/': elif v[0] != '/':
self.fail_json(rc=252, msg="the path for 'chdir' argument must be fully qualified") self.fail_json(rc=259, msg="the path for 'chdir' argument must be fully qualified")
params['chdir'] = v params['chdir'] = v
args = r.sub("", args) args = r.sub("", args)
params['args'] = args params['args'] = args