From 920b71984e75f5f78a358fc2865d40b6c3269ba7 Mon Sep 17 00:00:00 2001 From: Toshio Kuratomi Date: Mon, 23 Feb 2015 07:06:02 -0800 Subject: [PATCH] lists => frozenset as we're only using them in membership checks --- lib/ansible/playbook/play.py | 4 ++-- lib/ansible/playbook/task.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/ansible/playbook/play.py b/lib/ansible/playbook/play.py index 74aa6a9f798..8d81424f09e 100644 --- a/lib/ansible/playbook/play.py +++ b/lib/ansible/playbook/play.py @@ -43,13 +43,13 @@ class Play(object): # to catch typos and so forth -- these are userland names # and don't line up 1:1 with how they are stored - VALID_KEYS = [ + VALID_KEYS = frozenset(( 'hosts', 'name', 'vars', 'vars_prompt', 'vars_files', 'tasks', 'handlers', 'remote_user', 'user', 'port', 'include', 'accelerate', 'accelerate_port', 'accelerate_ipv6', 'sudo', 'sudo_user', 'connection', 'tags', 'gather_facts', 'serial', 'any_errors_fatal', 'roles', 'role_names', 'pre_tasks', 'post_tasks', 'max_fail_percentage', 'su', 'su_user', 'vault_password', 'no_log', 'environment', - ] + )) # ************************************************* diff --git a/lib/ansible/playbook/task.py b/lib/ansible/playbook/task.py index bdffba5527c..dd868ec8531 100644 --- a/lib/ansible/playbook/task.py +++ b/lib/ansible/playbook/task.py @@ -36,14 +36,14 @@ class Task(object): ] # to prevent typos and such - VALID_KEYS = [ + VALID_KEYS = frozenset(( 'name', 'meta', 'action', 'when', 'async', 'poll', 'notify', 'first_available_file', 'include', 'tags', 'register', 'ignore_errors', 'delegate_to', 'local_action', 'transport', 'remote_user', 'sudo', 'sudo_user', 'sudo_pass', 'when', 'connection', 'environment', 'args', 'any_errors_fatal', 'changed_when', 'failed_when', 'always_run', 'delay', 'retries', 'until', 'su', 'su_user', 'su_pass', 'no_log', 'run_once', - ] + )) def __init__(self, play, ds, module_vars=None, play_vars=None, play_file_vars=None, role_vars=None, role_params=None, default_vars=None, additional_conditions=None, role_name=None): ''' constructor loads from a task or handler datastructure '''