From 93472c3c542a68f5be45d4c2381a9d8e82f2f04e Mon Sep 17 00:00:00 2001 From: Dagobert Michelsen Date: Tue, 9 Aug 2016 14:47:00 +0200 Subject: [PATCH] Do not return failure when the package is installed and nothing is done (#1852) --- packaging/os/svr4pkg.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packaging/os/svr4pkg.py b/packaging/os/svr4pkg.py index 5d8bac17eaa..807e00f543b 100644 --- a/packaging/os/svr4pkg.py +++ b/packaging/os/svr4pkg.py @@ -225,9 +225,10 @@ def main(): else: result['changed'] = False + # rc will be none when the package already was installed and no action took place # Only return failed=False when the returncode is known to be good as there may be more # undocumented failure return codes - if rc not in (0, 2, 10, 20): + if rc not in (None, 0, 2, 10, 20): result['failed'] = True else: result['failed'] = False