cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

redfish_utils: fix reference to local variable 'systems_service' (#50298)

Browse source 
* fixes issue 50296

* fixes the indentation of the return statement

* Adds a conditional test into `_find_systems_resource()` to check the existence
of the Members of System resource

* updates the error message

* harden the conditional test

* Add a changelog
This commit is contained in:
Dhanuka 2019-01-11 19:46:20 +05:30 committed by John R Barker
parent 1ae365c112
commit 94a1d86d70
2 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
changelogs/fragments/50298-redfish_utils_fix_reference_to_local_variable_systems_service.yaml Normal file
View file

@ -0,0 +1,3 @@
---
bugfixes:
- redfish_utils - fix reference to local variable 'systems_service'

12
lib/ansible/module_utils/redfish_utils.py
View file

@ -133,10 +133,14 @@ class RedfishUtils(object):
if response['ret'] is False:
return response
data = response['data']
for member in data[u'Members']:
systems_service = member[u'@odata.id']
self.systems_uri = systems_service
return {'ret': True}
if data.get(u'Members'):
for member in data[u'Members']:
systems_service = member[u'@odata.id']
self.systems_uri = systems_service
return {'ret': True}
else:
return {'ret': False,
'msg': "ComputerSystem's Members array is either empty or missing"}
def _find_updateservice_resource(self, uri):
response = self.get_request(self.root_uri + uri)