From 973e36c6b69db9e473e72502c7a4a9ad2d9193e7 Mon Sep 17 00:00:00 2001 From: Bill Dodd Date: Thu, 19 Dec 2019 00:09:28 -0600 Subject: [PATCH] Fix version param in deprecate() call and update porting guide (#65894) * fix version= param in deprecate() call and update porting guide * add changelog fragment --- changelogs/fragments/65894-redfish-bios-attributes.yaml | 4 ++++ docs/docsite/rst/porting_guides/porting_guide_2.10.rst | 1 + .../modules/remote_management/redfish/redfish_config.py | 2 +- 3 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/65894-redfish-bios-attributes.yaml diff --git a/changelogs/fragments/65894-redfish-bios-attributes.yaml b/changelogs/fragments/65894-redfish-bios-attributes.yaml new file mode 100644 index 00000000000..e67fb5c4b7c --- /dev/null +++ b/changelogs/fragments/65894-redfish-bios-attributes.yaml @@ -0,0 +1,4 @@ +minor_changes: +- redfish_config - New ``bios_attributes`` option to allow setting multiple BIOS attributes in one command. +deprecated_features: +- redfish_config - Deprecate ``bios_attribute_name`` and ``bios_attribute_value`` in favor of new `bios_attributes`` option. diff --git a/docs/docsite/rst/porting_guides/porting_guide_2.10.rst b/docs/docsite/rst/porting_guides/porting_guide_2.10.rst index bda0924fd8c..428ecf31d0f 100644 --- a/docs/docsite/rst/porting_guides/porting_guide_2.10.rst +++ b/docs/docsite/rst/porting_guides/porting_guide_2.10.rst @@ -69,6 +69,7 @@ The following functionality will be removed in Ansible 2.14. Please update updat * :ref:`ec2_key `: the ``wait_timeout`` option will be removed. It has had no effect since Ansible 2.5. * :ref:`ec2_lc `: the ``associate_public_ip_address`` option will be removed. It has always been ignored by the module. * :ref:`iam_policy `: the ``policy_document`` option will be removed. To maintain the existing behavior use the ``policy_json`` option and read the file with the ``lookup`` plugin. +* :ref:`redfish_config `: the ``bios_attribute_name`` and ``bios_attribute_value`` options will be removed. To maintain the existing behavior use the ``bios_attributes`` option instead. diff --git a/lib/ansible/modules/remote_management/redfish/redfish_config.py b/lib/ansible/modules/remote_management/redfish/redfish_config.py index e80ed2c09e6..ce1889957b6 100644 --- a/lib/ansible/modules/remote_management/redfish/redfish_config.py +++ b/lib/ansible/modules/remote_management/redfish/redfish_config.py @@ -276,7 +276,7 @@ def main(): 'bios_attribute_value'] module.deprecate(msg='The bios_attribute_name/bios_attribute_value ' 'options are deprecated. Use bios_attributes instead', - version='2.10') + version='2.14') # boot order boot_order = module.params['boot_order']