Add diff for both file contents and file attributes to lineinfile
Using the difflist feature added in ansible/ansible@c337293 we can add two diffs to the `diff` dict returned as JSON: A `before` and `after` pair of changed file contents and the diff of the file attributes. n.b.: the difflist handling from the above commit is logically broken. PR will follow. Example output: TASK [change line and mode] ************************************************************ changed: [localhost] --- before: /tmp/sshd_config (content) +++ after: /tmp/sshd_config (content) @@ -65,21 +65,21 @@ X11DisplayOffset 10 PrintMotd no PrintLastLog yes TCPKeepAlive yes #UseLogin no #MaxStartups 10:30:60 #Banner /etc/issue.net # Allow client to pass locale environment variables -AcceptEnv LANG LC_* +AcceptEnv LANG LC_* GF_ENV_* Subsystem sftp /usr/lib/openssh/sftp-server # Set this to 'yes' to enable PAM authentication, account processing, # and session processing. If this is enabled, PAM authentication will # be allowed through the ChallengeResponseAuthentication and # PasswordAuthentication. Depending on your PAM configuration, # PAM authentication via ChallengeResponseAuthentication may bypass # the setting of "PermitRootLogin without-password". # If you just want the PAM account and session checks to run without --- before: /tmp/sshd_config (file attributes) +++ after: /tmp/sshd_config (file attributes) @@ -1,3 +1,3 @@ { - "mode": "0700" + "mode": "0644" }
This commit is contained in:
parent
c8d5fdaf27
commit
99ba594f0a
1 changed files with 43 additions and 9 deletions
|
@ -167,10 +167,10 @@ def write_changes(module,lines,dest):
|
||||||
if valid:
|
if valid:
|
||||||
module.atomic_move(tmpfile, os.path.realpath(dest))
|
module.atomic_move(tmpfile, os.path.realpath(dest))
|
||||||
|
|
||||||
def check_file_attrs(module, changed, message):
|
def check_file_attrs(module, changed, message, diff):
|
||||||
|
|
||||||
file_args = module.load_file_common_arguments(module.params)
|
file_args = module.load_file_common_arguments(module.params)
|
||||||
if module.set_fs_attributes_if_different(file_args, False):
|
if module.set_fs_attributes_if_different(file_args, False, diff=diff):
|
||||||
|
|
||||||
if changed:
|
if changed:
|
||||||
message += " and "
|
message += " and "
|
||||||
|
@ -183,6 +183,11 @@ def check_file_attrs(module, changed, message):
|
||||||
def present(module, dest, regexp, line, insertafter, insertbefore, create,
|
def present(module, dest, regexp, line, insertafter, insertbefore, create,
|
||||||
backup, backrefs):
|
backup, backrefs):
|
||||||
|
|
||||||
|
diff = {'before': '',
|
||||||
|
'after': '',
|
||||||
|
'before_header': '%s (content)' % dest,
|
||||||
|
'after_header': '%s (content)' % dest}
|
||||||
|
|
||||||
if not os.path.exists(dest):
|
if not os.path.exists(dest):
|
||||||
if not create:
|
if not create:
|
||||||
module.fail_json(rc=257, msg='Destination %s does not exist !' % dest)
|
module.fail_json(rc=257, msg='Destination %s does not exist !' % dest)
|
||||||
|
@ -195,7 +200,8 @@ def present(module, dest, regexp, line, insertafter, insertbefore, create,
|
||||||
lines = f.readlines()
|
lines = f.readlines()
|
||||||
f.close()
|
f.close()
|
||||||
|
|
||||||
msg = ""
|
if module._diff:
|
||||||
|
diff['before'] = ''.join(lines)
|
||||||
|
|
||||||
if regexp is not None:
|
if regexp is not None:
|
||||||
mre = re.compile(regexp)
|
mre = re.compile(regexp)
|
||||||
|
@ -271,6 +277,9 @@ def present(module, dest, regexp, line, insertafter, insertbefore, create,
|
||||||
msg = 'line added'
|
msg = 'line added'
|
||||||
changed = True
|
changed = True
|
||||||
|
|
||||||
|
if module._diff:
|
||||||
|
diff['after'] = ''.join(lines)
|
||||||
|
|
||||||
backupdest = ""
|
backupdest = ""
|
||||||
if changed and not module.check_mode:
|
if changed and not module.check_mode:
|
||||||
if backup and os.path.exists(dest):
|
if backup and os.path.exists(dest):
|
||||||
|
@ -278,10 +287,16 @@ def present(module, dest, regexp, line, insertafter, insertbefore, create,
|
||||||
write_changes(module, lines, dest)
|
write_changes(module, lines, dest)
|
||||||
|
|
||||||
if module.check_mode and not os.path.exists(dest):
|
if module.check_mode and not os.path.exists(dest):
|
||||||
module.exit_json(changed=changed, msg=msg, backup=backupdest)
|
module.exit_json(changed=changed, msg=msg, backup=backupdest, diff=diff)
|
||||||
|
|
||||||
msg, changed = check_file_attrs(module, changed, msg)
|
attr_diff = {}
|
||||||
module.exit_json(changed=changed, msg=msg, backup=backupdest)
|
msg, changed = check_file_attrs(module, changed, msg, attr_diff)
|
||||||
|
|
||||||
|
attr_diff['before_header'] = '%s (file attributes)' % dest
|
||||||
|
attr_diff['after_header'] = '%s (file attributes)' % dest
|
||||||
|
|
||||||
|
difflist = [diff, attr_diff]
|
||||||
|
module.exit_json(changed=changed, msg=msg, backup=backupdest, diff=difflist)
|
||||||
|
|
||||||
|
|
||||||
def absent(module, dest, regexp, line, backup):
|
def absent(module, dest, regexp, line, backup):
|
||||||
|
@ -289,11 +304,19 @@ def absent(module, dest, regexp, line, backup):
|
||||||
if not os.path.exists(dest):
|
if not os.path.exists(dest):
|
||||||
module.exit_json(changed=False, msg="file not present")
|
module.exit_json(changed=False, msg="file not present")
|
||||||
|
|
||||||
msg = ""
|
msg = ''
|
||||||
|
diff = {'before': '',
|
||||||
|
'after': '',
|
||||||
|
'before_header': '%s (content)' % dest,
|
||||||
|
'after_header': '%s (content)' % dest}
|
||||||
|
|
||||||
f = open(dest, 'rb')
|
f = open(dest, 'rb')
|
||||||
lines = f.readlines()
|
lines = f.readlines()
|
||||||
f.close()
|
f.close()
|
||||||
|
|
||||||
|
if module._diff:
|
||||||
|
diff['before'] = ''.join(lines)
|
||||||
|
|
||||||
if regexp is not None:
|
if regexp is not None:
|
||||||
cre = re.compile(regexp)
|
cre = re.compile(regexp)
|
||||||
found = []
|
found = []
|
||||||
|
@ -309,6 +332,10 @@ def absent(module, dest, regexp, line, backup):
|
||||||
|
|
||||||
lines = filter(matcher, lines)
|
lines = filter(matcher, lines)
|
||||||
changed = len(found) > 0
|
changed = len(found) > 0
|
||||||
|
|
||||||
|
if module._diff:
|
||||||
|
diff['after'] = ''.join(lines)
|
||||||
|
|
||||||
backupdest = ""
|
backupdest = ""
|
||||||
if changed and not module.check_mode:
|
if changed and not module.check_mode:
|
||||||
if backup:
|
if backup:
|
||||||
|
@ -318,8 +345,15 @@ def absent(module, dest, regexp, line, backup):
|
||||||
if changed:
|
if changed:
|
||||||
msg = "%s line(s) removed" % len(found)
|
msg = "%s line(s) removed" % len(found)
|
||||||
|
|
||||||
msg, changed = check_file_attrs(module, changed, msg)
|
attr_diff = {}
|
||||||
module.exit_json(changed=changed, found=len(found), msg=msg, backup=backupdest)
|
msg, changed = check_file_attrs(module, changed, msg, attr_diff)
|
||||||
|
|
||||||
|
attr_diff['before_header'] = '%s (file attributes)' % dest
|
||||||
|
attr_diff['after_header'] = '%s (file attributes)' % dest
|
||||||
|
|
||||||
|
difflist = [diff, attr_diff]
|
||||||
|
|
||||||
|
module.exit_json(changed=changed, found=len(found), msg=msg, backup=backupdest, diff=difflist)
|
||||||
|
|
||||||
|
|
||||||
def main():
|
def main():
|
||||||
|
|
Loading…
Reference in a new issue