VMware: Added check for temp_version type in vmware_guest(#64376)
Fixes: #64374 * Adding tests for create VM with interger version and latest version
This commit is contained in:
parent
b475e0408c
commit
9a54070fa2
2 changed files with 48 additions and 2 deletions
|
@ -1282,7 +1282,7 @@ class PyVmomiHelper(PyVmomi):
|
|||
if 'version' in self.params['hardware']:
|
||||
hw_version_check_failed = False
|
||||
temp_version = self.params['hardware'].get('version', 10)
|
||||
if temp_version.lower() == 'latest':
|
||||
if isinstance(temp_version, str) and temp_version.lower() == 'latest':
|
||||
# Check is to make sure vm_obj is not of type template
|
||||
if vm_obj and not vm_obj.config.template:
|
||||
try:
|
||||
|
|
|
@ -3,13 +3,59 @@
|
|||
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
|
||||
# Skipping out idepotency test untill issue fixed in reconfigure_vm() become_method
|
||||
|
||||
- name: Create VM with hardware version 12
|
||||
vmware_guest:
|
||||
validate_certs: False
|
||||
hostname: "{{ vcenter_hostname }}"
|
||||
username: "{{ vcenter_username }}"
|
||||
password: "{{ vcenter_password }}"
|
||||
name: test_vm_version12
|
||||
guest_id: centos7_64Guest
|
||||
datacenter: "{{ dc1 }}"
|
||||
folder: "{{ f0 }}"
|
||||
datastore: '{{ ds2 }}'
|
||||
hardware:
|
||||
num_cpus: 4
|
||||
memory_mb: 1028
|
||||
version: 12
|
||||
state: present
|
||||
register: create_vm_with_version_12
|
||||
|
||||
- name: assert that changes were made
|
||||
assert:
|
||||
that:
|
||||
- create_vm_with_version_12 is changed
|
||||
|
||||
- name: Deploy New VM with latest hardware version
|
||||
vmware_guest:
|
||||
validate_certs: False
|
||||
hostname: "{{ vcenter_hostname }}"
|
||||
username: "{{ vcenter_username }}"
|
||||
password: "{{ vcenter_password }}"
|
||||
name: test_vm_version_latest
|
||||
guest_id: centos7_64Guest
|
||||
datacenter: "{{ dc1 }}"
|
||||
folder: "{{ f0 }}"
|
||||
datastore: '{{ ds2 }}'
|
||||
hardware:
|
||||
num_cpus: 4
|
||||
memory_mb: 1028
|
||||
version: latest
|
||||
state: present
|
||||
register: deploy_vm_to_latest
|
||||
|
||||
- name: assert that changes were made
|
||||
assert:
|
||||
that:
|
||||
- deploy_vm_to_latest is changed
|
||||
|
||||
- name: Upgrade VM to latest version
|
||||
vmware_guest:
|
||||
validate_certs: False
|
||||
hostname: "{{ vcenter_hostname }}"
|
||||
username: "{{ vcenter_username }}"
|
||||
password: "{{ vcenter_password }}"
|
||||
name: test_vm1
|
||||
name: test_vm_version12
|
||||
guest_id: centos7_64Guest
|
||||
datacenter: "{{ dc1 }}"
|
||||
folder: "{{ f0 }}"
|
||||
|
|
Loading…
Add table
Reference in a new issue