cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Close file after using it (#59000)

Browse source
This commit is contained in:
Ewoud Kohl van Wijngaarden 2019-07-16 17:07:28 +02:00 committed by James Cammarata
parent 2ed78b650f
commit 9c5b3401ff
1 changed files with 16 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
lib/ansible/parsing/plugin_docs.py
View file

@ -90,30 +90,30 @@ def read_docstub(filename):
operations like ansible-doc -l. operations like ansible-doc -l.
""" """
t_module_data = open(filename, 'r')
in_documentation = False in_documentation = False
capturing = False capturing = False
indent_detection = '' indent_detection = ''
doc_stub = [] doc_stub = []
for line in t_module_data: with open(filename, 'r') as t_module_data:
if in_documentation: for line in t_module_data:
# start capturing the stub until indentation returns if in_documentation:
if capturing and line.startswith(indent_detection): # start capturing the stub until indentation returns
doc_stub.append(line) if capturing and line.startswith(indent_detection):
doc_stub.append(line)
elif capturing and not line.startswith(indent_detection): elif capturing and not line.startswith(indent_detection):
break break
elif line.lstrip().startswith('short_description:'): elif line.lstrip().startswith('short_description:'):
capturing = True capturing = True
# Detect that the short_description continues on the next line if it's indented more # Detect that the short_description continues on the next line if it's indented more
# than short_description itself. # than short_description itself.
indent_detection = ' ' * (len(line) - len(line.lstrip()) + 1) indent_detection = ' ' * (len(line) - len(line.lstrip()) + 1)
doc_stub.append(line) doc_stub.append(line)
elif line.startswith('DOCUMENTATION') and '=' in line: elif line.startswith('DOCUMENTATION') and '=' in line:
in_documentation = True in_documentation = True
short_description = r''.join(doc_stub).strip().rstrip('.') short_description = r''.join(doc_stub).strip().rstrip('.')
data = AnsibleLoader(short_description, file_name=filename).get_single_data() data = AnsibleLoader(short_description, file_name=filename).get_single_data()