cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fixed a bug where the Route 53 Health Check would add a new health check instead of updating an existing one when the user has > 100 health checks (#58539)

Browse source
This commit is contained in:
Mark Dierolf 2019-07-11 14:57:09 -07:00 committed by Jill R
parent 9cb78b4826
commit 9fc710f657
1 changed files with 19 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
lib/ansible/modules/cloud/amazon/route53_health_check.py
View file

@ -145,17 +145,25 @@ from ansible.module_utils.ec2 import ec2_argument_spec, get_aws_connection_info
# string_match if not previously enabled # string_match if not previously enabled
def find_health_check(conn, wanted): def find_health_check(conn, wanted):
"""Searches for health checks that have the exact same set of immutable values""" """Searches for health checks that have the exact same set of immutable values"""
for check in conn.get_list_health_checks().HealthChecks:
config = check.HealthCheckConfig results = conn.get_list_health_checks()
if (
config.get('IPAddress') == wanted.ip_addr and while True:
config.get('FullyQualifiedDomainName') == wanted.fqdn and for check in results.HealthChecks:
config.get('Type') == wanted.hc_type and config = check.HealthCheckConfig
config.get('RequestInterval') == str(wanted.request_interval) and if (
config.get('Port') == str(wanted.port) config.get('IPAddress') == wanted.ip_addr and
): config.get('FullyQualifiedDomainName') == wanted.fqdn and
return check config.get('Type') == wanted.hc_type and
return None config.get('RequestInterval') == str(wanted.request_interval) and
config.get('Port') == str(wanted.port)
):
return check
if (results.IsTruncated == 'true'):
results = conn.get_list_health_checks(marker=results.NextMarker)
else:
return None
def to_health_check(config): def to_health_check(config):