cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

cloudscale_volume: fail fast on volume type change (#52231)

Browse source 
* cloudscale_volume: fail fast on volume type change

Currently a volume gets resized before the type change check. With this
change, we check early and ensure we fail before any changes made.

* fix too many blank lines
This commit is contained in:
René Moser 2019-02-18 18:48:47 +01:00 committed by John R Barker
parent fcb6f136cd
commit a1ec74334a
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lib/ansible/modules/cloud/cloudscale/cloudscale_volume.py
View file

@ -261,18 +261,18 @@ def main():
volume.delete() volume.delete()
if module.params['state'] == 'present': if module.params['state'] == 'present':
for param, conv in (('server_uuids', set), ('size_gb', int)):
if module.params[param] is None:
continue
if conv(volume.info[param]) != conv(module.params[param]):
volume.update(param)
if (module.params['type'] is not None if (module.params['type'] is not None
and volume.info['type'] != module.params['type']): and volume.info['type'] != module.params['type']):
module.fail_json( module.fail_json(
msg='Cannot change type of an existing volume.', msg='Cannot change type of an existing volume.',
) )
for param, conv in (('server_uuids', set), ('size_gb', int)):
if module.params[param] is None:
continue
if conv(volume.info[param]) != conv(module.params[param]):
volume.update(param)
module.exit_json(changed=volume.changed, **volume.info) module.exit_json(changed=volume.changed, **volume.info)