Split up platform cleanup in tests. (#67320)

* Split up platform cleanup for git test.

* Split up platform cleanup for ansible-galaxy test.

test/integration/targets/ansible-galaxy/cleanup-default.yml

@@ -0,0 +1,5 @@
+- name: remove unwanted packages
+  package:
+    name: git
+    state: absent
+  when: git_install.changed

test/integration/targets/ansible-galaxy/cleanup-freebsd.yml

@@ -0,0 +1,6 @@
+- name: remove auto-installed packages from FreeBSD
+  pkgng:
+    name: git
+    state: absent
+    autoremove: yes
+  when: git_install.changed

test/integration/targets/ansible-galaxy/cleanup.yml

@@ -2,15 +2,10 @@
   vars:
     git_install: '{{ lookup("file", lookup("env", "OUTPUT_DIR") + "/git_install.json") | from_json }}'
   tasks:
-    - name: remove unwanted packages
+    - name: cleanup
-      package:
+      include_tasks: "{{ cleanup_filename }}"
-        name: git
+      with_first_found:
-        state: absent
+        - "cleanup-{{ ansible_distribution | lower }}.yml"
-      when: git_install.changed
+        - "cleanup-default.yml"
-
+      loop_control:
-    - name: remove auto-installed packages from FreeBSD
+        loop_var: cleanup_filename
-      pkgng:
-        name: git
-        state: absent
-        autoremove: yes
-      when: git_install.changed and ansible_distribution == "FreeBSD"

test/integration/targets/git/handlers/cleanup-default.yml

@@ -0,0 +1,6 @@
+# TODO remove everything we'd installed (see git_required_packages), not just git
+# problem is that we should not remove what we hadn't installed
+- name: remove git
+  package:
+    name: git
+    state: absent

test/integration/targets/git/handlers/cleanup-freebsd.yml

@@ -0,0 +1,5 @@
+- name: remove git fromn FreeBSD
+  pkgng:
+    name: git
+    state: absent
+    autoremove: yes

test/integration/targets/git/handlers/main.yml

@@ -1,13 +1,7 @@
-# TODO remove everything we'd installed (see git_required_packages), not just git
+- name: cleanup
-# problem is that we should not remove what we hadn't installed
+  include_tasks: "{{ cleanup_filename }}"
-- name: remove git
+  with_first_found:
-  package:
+    - "cleanup-{{ ansible_distribution | lower }}.yml"
-    name: git
+    - "cleanup-default.yml"
-    state: absent
+  loop_control:
-
+    loop_var: cleanup_filename
-- name: remove git from FreeBSD
-  pkgng:
-    name: git
-    state: absent
-    autoremove: yes
-  when: ansible_distribution == "FreeBSD"

test/integration/targets/git/tasks/setup.yml

@@ -13,8 +13,7 @@
     name: '{{ item }}'
   when: ansible_distribution != "MacOSX"
   notify:
-    - remove git
+    - cleanup
-    - remove git from FreeBSD
   with_items: "{{ git_required_packages[ansible_os_family | default('default') ] | default(git_required_packages.default) }}"
 
 - name: SETUP | verify that git is installed so this test can continue