cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Using the wrong variable (#22386)

Browse source
This commit is contained in:
Tim Rupp 2017-03-08 00:43:36 -08:00 committed by John R Barker
parent fbf55886ba
commit a8910e78ca
1 changed files with 19 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
lib/ansible/module_utils/f5_utils.py
View file

@ -287,19 +287,26 @@ class AnsibleF5Parameters(object):
self._values = defaultdict(lambda: None) self._values = defaultdict(lambda: None)
if params: if params:
for k,v in iteritems(params): for k,v in iteritems(params):
try: if self.api_map is not None and k in self.api_map:
# Handle weird API parameters like `dns.proxy.__iter__` by # Handle weird API parameters like `dns.proxy.__iter__` by
# using a map provided by the module developer # using a map provided by the module developer
setattr(self, self.api_params[k], v) class_attr = getattr(type(self), self.api_map[k], None)
except (KeyError, TypeError): if isinstance(class_attr, property):
# Otherwise set things to attributes as normal # There is a mapped value for the api_map key
if class_attr.fset is None:
# If the mapped value does not have an associated setter
self._values[self.api_map[k]] = v
else:
# The mapped value has a setter
setattr(self, self.api_map[k], v)
else:
# If the mapped value is not a @property
self._values[self.api_map[k]] = v
try: try:
# There is no map, or the provided param is not in the api_map
setattr(self, k, v) setattr(self, k, v)
except AttributeError: except AttributeError:
# If all else fails, stash them in a dictionary. For # At a minimum put it in values.
# instance, if the module developer forgot a map,
# or said developer didn't need to add a setter for
# the property
self._values[k] = v self._values[k] = v
def __getattr__(self, item): def __getattr__(self, item):