cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Enable pipelining for jail connection plugin

Browse source
This commit is contained in:
Toshio Kuratomi 2016-03-16 11:39:51 -07:00
parent de306eb5da
commit a8acd7f93e
1 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/ansible/plugins/connection/jail.py
View file

@ -45,7 +45,7 @@ class Connection(ConnectionBase):
transport = 'jail' transport = 'jail'
# Pipelining may work. Someone needs to test by setting this to True and # Pipelining may work. Someone needs to test by setting this to True and
# having pipelining=True in their ansible.cfg # having pipelining=True in their ansible.cfg
has_pipelining = False has_pipelining = True
# Some become_methods may work in v2 (sudo works for other chroot-based # Some become_methods may work in v2 (sudo works for other chroot-based
# plugins while su seems to be failing). If some work, check chroot.py to # plugins while su seems to be failing). If some work, check chroot.py to
# see how to disable just some methods. # see how to disable just some methods.
@ -119,13 +119,6 @@ class Connection(ConnectionBase):
''' run a command on the jail ''' ''' run a command on the jail '''
super(Connection, self).exec_command(cmd, in_data=in_data, sudoable=sudoable) super(Connection, self).exec_command(cmd, in_data=in_data, sudoable=sudoable)
# TODO: Check whether we can send the command to stdin via
# p.communicate(in_data)
# If we can, then we can change this plugin to has_pipelining=True and
# remove the error if in_data is given.
if in_data:
raise AnsibleError("Internal Error: this module does not support optimized module pipelining")
p = self._buffered_exec_command(cmd) p = self._buffered_exec_command(cmd)
stdout, stderr = p.communicate(in_data) stdout, stderr = p.communicate(in_data)