From a8e133105cf93e7998b266703f147c65a863f9e1 Mon Sep 17 00:00:00 2001 From: ShachafGoldstein <shachaf.gold@gmail.com> Date: Mon, 10 Jun 2019 23:26:01 +0300 Subject: [PATCH] win_domain_group_membership: Fix missing @extra_vars on Get-ADObject to support different domain and credentials for retrieval (#57429) * win_domain_group_membership - Fix missing @extra_vars on Get-ADObject to support dirrent domain and credentials for retrival * win_domain_group_membership - Fix missing extra_vars on Get-ADObject --- ...domain_group_membership-Fix-missing-vars-for-Get-command.yml | 2 ++ lib/ansible/modules/windows/win_domain_group_membership.ps1 | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/win_domain_group_membership-Fix-missing-vars-for-Get-command.yml diff --git a/changelogs/fragments/win_domain_group_membership-Fix-missing-vars-for-Get-command.yml b/changelogs/fragments/win_domain_group_membership-Fix-missing-vars-for-Get-command.yml new file mode 100644 index 00000000000..105ad4282cd --- /dev/null +++ b/changelogs/fragments/win_domain_group_membership-Fix-missing-vars-for-Get-command.yml @@ -0,0 +1,2 @@ +bugfixes: + - "win_domain_group_membership - Fix missing @extra_vars on Get-ADObject to support dirrent domain and credentials for retrival (https://github.com/ansible/ansible/issues/57404)" diff --git a/lib/ansible/modules/windows/win_domain_group_membership.ps1 b/lib/ansible/modules/windows/win_domain_group_membership.ps1 index 7b8564364aa..744633ea3d5 100644 --- a/lib/ansible/modules/windows/win_domain_group_membership.ps1 +++ b/lib/ansible/modules/windows/win_domain_group_membership.ps1 @@ -52,7 +52,7 @@ $members_before = Get-AdGroupMember -Identity $name @extra_args $pure_members = [System.Collections.Generic.List`1[String]]@() foreach ($member in $members) { - $group_member = Get-ADObject -Filter "SamAccountName -eq '$member' -and $ad_object_class_filter" -Properties objectSid, sAMAccountName + $group_member = Get-ADObject -Filter "SamAccountName -eq '$member' -and $ad_object_class_filter" -Properties objectSid, sAMAccountName @extra_vars if (!$group_member) { Fail-Json -obj $result "Could not find domain user, group, service account or computer named $member" }