From a90de29cebbc7fddee01d684b8d1262134780d93 Mon Sep 17 00:00:00 2001 From: Toshio Kuratomi Date: Mon, 23 Nov 2015 16:23:41 -0800 Subject: [PATCH] Minor simplification of code --- lib/ansible/modules/cloud/amazon/ec2.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ansible/modules/cloud/amazon/ec2.py b/lib/ansible/modules/cloud/amazon/ec2.py index 5a72ab67abc..83c5ef151ea 100755 --- a/lib/ansible/modules/cloud/amazon/ec2.py +++ b/lib/ansible/modules/cloud/amazon/ec2.py @@ -888,9 +888,9 @@ def create_instances(module, ec2, vpc, override_count=None): grp_details = ec2.get_all_security_groups() if isinstance(group_name, basestring): group_name = [group_name] - unmatched = list(set(group_name) - set([str(grp.name) for grp in grp_details])) + unmatched = set(group_name).difference(str(grp.name) for grp in grp_details) if len(unmatched) > 0: - module.fail_json(msg="the following group names are not valid: %s" % ','.join(unmatched)) + module.fail_json(msg="The following group names are not valid: %s" % ', '.join(unmatched)) group_id = [ str(grp.id) for grp in grp_details if str(grp.name) in group_name ] # Now we try to lookup the group id testing if group exists. elif group_id: