cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

nsupdate: rename rc(_str) to dns_rc(_str) (#21341)

Browse source 
This prevent module to fail when removing a removed record which returned RC 8 (NXRRSET)
This commit is contained in:
Loïc Blot 2017-02-14 12:45:44 +01:00 committed by John R Barker
parent ff68526291
commit acda9e9c85
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
lib/ansible/modules/network/nsupdate.py
View file

@ -101,6 +101,7 @@ EXAMPLES = '''
zone: "example.org"
record: "puppet"
type: "CNAME"
state: absent
'''
RETURN = '''
@ -133,12 +134,12 @@ zone:
returned: success
type: string
sample: 'example.org.'
rc:
dns_rc:
description: dnspython return code
returned: always
type: int
sample: 4
rc_str:
dns_rc_str:
description: dnspython return code (string representation)
returned: always
type: string
@ -342,13 +343,16 @@ def main():
elif module.params["state"] == 'present':
result = record.create_or_update_record()
result['rc'] = record.dns_rc
result['rc_str'] = dns.rcode.to_text(record.dns_rc)
result['dns_rc'] = record.dns_rc
result['dns_rc_str'] = dns.rcode.to_text(record.dns_rc)
if result['failed']:
module.fail_json(**result)
else:
result['record'] = {'zone': record.zone, 'record': module.params['record'], 'type': module.params['type'],
'ttl': module.params['ttl'], 'value': module.params['value']}
result['record'] = dict(zone=record.zone,
record=module.params['record'],
type=module.params['type'],
ttl=module.params['ttl'],
value=module.params['value'])
module.exit_json(**result)