Merge pull request #43 from drob/postgresql-socket
Adds login_unix_socket options to postgresql modules. TODO: factor this out into common code as we did for ec2 and others.
This commit is contained in:
commit
adec837306
3 changed files with 54 additions and 17 deletions
|
@ -44,6 +44,11 @@ options:
|
||||||
- Host running the database
|
- Host running the database
|
||||||
required: false
|
required: false
|
||||||
default: localhost
|
default: localhost
|
||||||
|
login_unix_socket:
|
||||||
|
description
|
||||||
|
- Path to a Unix domain socket for local connections
|
||||||
|
required: false
|
||||||
|
default: null
|
||||||
owner:
|
owner:
|
||||||
description:
|
description:
|
||||||
- Name of the role to set as owner of the database
|
- Name of the role to set as owner of the database
|
||||||
|
@ -226,6 +231,7 @@ def main():
|
||||||
login_user=dict(default="postgres"),
|
login_user=dict(default="postgres"),
|
||||||
login_password=dict(default=""),
|
login_password=dict(default=""),
|
||||||
login_host=dict(default=""),
|
login_host=dict(default=""),
|
||||||
|
login_unix_socket=dict(default=""),
|
||||||
port=dict(default="5432"),
|
port=dict(default="5432"),
|
||||||
db=dict(required=True, aliases=['name']),
|
db=dict(required=True, aliases=['name']),
|
||||||
owner=dict(default=""),
|
owner=dict(default=""),
|
||||||
|
@ -262,6 +268,12 @@ def main():
|
||||||
}
|
}
|
||||||
kw = dict( (params_map[k], v) for (k, v) in module.params.iteritems()
|
kw = dict( (params_map[k], v) for (k, v) in module.params.iteritems()
|
||||||
if k in params_map and v != '' )
|
if k in params_map and v != '' )
|
||||||
|
|
||||||
|
# If a login_unix_socket is specified, incorporate it here.
|
||||||
|
is_localhost = "host" not in kw or kw["host"] == "" or kw["host"] == "localhost"
|
||||||
|
if is_localhost and module.params["login_unix_socket"] != "":
|
||||||
|
kw["host"] = module.params["login_unix_socket"]
|
||||||
|
|
||||||
try:
|
try:
|
||||||
db_connection = psycopg2.connect(database="template1", **kw)
|
db_connection = psycopg2.connect(database="template1", **kw)
|
||||||
# Enable autocommit so we can create databases
|
# Enable autocommit so we can create databases
|
||||||
|
|
|
@ -99,6 +99,12 @@ options:
|
||||||
- Database port to connect to.
|
- Database port to connect to.
|
||||||
required: no
|
required: no
|
||||||
default: 5432
|
default: 5432
|
||||||
|
unix_socket:
|
||||||
|
description
|
||||||
|
- Path to a Unix domain socket for local connections.
|
||||||
|
- 'Alias: I(login_unix_socket)'
|
||||||
|
required: false
|
||||||
|
default: null
|
||||||
login:
|
login:
|
||||||
description:
|
description:
|
||||||
- The username to authenticate with.
|
- The username to authenticate with.
|
||||||
|
@ -267,6 +273,12 @@ class Connection(object):
|
||||||
}
|
}
|
||||||
kw = dict( (params_map[k], getattr(params, k)) for k in params_map
|
kw = dict( (params_map[k], getattr(params, k)) for k in params_map
|
||||||
if getattr(params, k) != '' )
|
if getattr(params, k) != '' )
|
||||||
|
|
||||||
|
# If a unix_socket is specified, incorporate it here.
|
||||||
|
is_localhost = "host" not in kw or kw["host"] == "" or kw["host"] == "localhost"
|
||||||
|
if is_localhost and params.unix_socket != "":
|
||||||
|
kw["host"] = params.unix_socket
|
||||||
|
|
||||||
self.connection = psycopg2.connect(**kw)
|
self.connection = psycopg2.connect(**kw)
|
||||||
self.cursor = self.connection.cursor()
|
self.cursor = self.connection.cursor()
|
||||||
|
|
||||||
|
@ -520,6 +532,7 @@ def main():
|
||||||
aliases=['admin_option']),
|
aliases=['admin_option']),
|
||||||
host=dict(default='', aliases=['login_host']),
|
host=dict(default='', aliases=['login_host']),
|
||||||
port=dict(type='int', default=5432),
|
port=dict(type='int', default=5432),
|
||||||
|
unix_socket=dict(default='', aliases=['login_unix_socket']),
|
||||||
login=dict(default='postgres', aliases=['login_user']),
|
login=dict(default='postgres', aliases=['login_user']),
|
||||||
password=dict(default='', aliases=['login_password'])
|
password=dict(default='', aliases=['login_password'])
|
||||||
),
|
),
|
||||||
|
|
|
@ -78,6 +78,11 @@ options:
|
||||||
- Host running PostgreSQL.
|
- Host running PostgreSQL.
|
||||||
required: false
|
required: false
|
||||||
default: localhost
|
default: localhost
|
||||||
|
login_unix_socket:
|
||||||
|
description
|
||||||
|
- Path to a Unix domain socket for local connections
|
||||||
|
required: false
|
||||||
|
default: null
|
||||||
priv:
|
priv:
|
||||||
description:
|
description:
|
||||||
- "PostgreSQL privileges string in the format: C(table:priv1,priv2)"
|
- "PostgreSQL privileges string in the format: C(table:priv1,priv2)"
|
||||||
|
@ -456,6 +461,7 @@ def main():
|
||||||
login_user=dict(default="postgres"),
|
login_user=dict(default="postgres"),
|
||||||
login_password=dict(default=""),
|
login_password=dict(default=""),
|
||||||
login_host=dict(default=""),
|
login_host=dict(default=""),
|
||||||
|
login_unix_socket=dict(default=""),
|
||||||
user=dict(required=True, aliases=['name']),
|
user=dict(required=True, aliases=['name']),
|
||||||
password=dict(default=None),
|
password=dict(default=None),
|
||||||
state=dict(default="present", choices=["absent", "present"]),
|
state=dict(default="present", choices=["absent", "present"]),
|
||||||
|
@ -504,6 +510,12 @@ def main():
|
||||||
}
|
}
|
||||||
kw = dict( (params_map[k], v) for (k, v) in module.params.iteritems()
|
kw = dict( (params_map[k], v) for (k, v) in module.params.iteritems()
|
||||||
if k in params_map and v != "" )
|
if k in params_map and v != "" )
|
||||||
|
|
||||||
|
# If a login_unix_socket is specified, incorporate it here.
|
||||||
|
is_localhost = "host" not in kw or kw["host"] == "" or kw["host"] == "localhost"
|
||||||
|
if is_localhost and module.params["login_unix_socket"] != "":
|
||||||
|
kw["host"] = module.params["login_unix_socket"]
|
||||||
|
|
||||||
try:
|
try:
|
||||||
db_connection = psycopg2.connect(**kw)
|
db_connection = psycopg2.connect(**kw)
|
||||||
cursor = db_connection.cursor()
|
cursor = db_connection.cursor()
|
||||||
|
|
Loading…
Reference in a new issue