From af5db3e4a9d7577a4c9d927eb5418b46b0ba5dc7 Mon Sep 17 00:00:00 2001 From: Matt Clay Date: Fri, 12 May 2017 15:47:28 +0800 Subject: [PATCH] Revert "Add support for on-demand coverage on Shippable." This reverts commit 7b3f0b88701b08b05e9f850d329aaa6db98c9e4c. --- test/utils/shippable/cloud.sh | 2 +- test/utils/shippable/freebsd.sh | 2 +- test/utils/shippable/linux.sh | 2 +- test/utils/shippable/network.sh | 4 ++-- test/utils/shippable/osx.sh | 3 +-- test/utils/shippable/other.sh | 4 ++-- test/utils/shippable/shippable.sh | 6 ------ test/utils/shippable/windows.sh | 4 ++-- 8 files changed, 10 insertions(+), 17 deletions(-) diff --git a/test/utils/shippable/cloud.sh b/test/utils/shippable/cloud.sh index 9d101db56a8..37535cf5e7b 100755 --- a/test/utils/shippable/cloud.sh +++ b/test/utils/shippable/cloud.sh @@ -8,4 +8,4 @@ IFS='/:' read -ra args <<< "${TEST}" image="ansible/ansible:${args[1]}" target="posix/ci/cloud/" -ansible-test integration --color -v --retry-on-error "${target}" --docker "${image}" "${COVERAGE}" +ansible-test integration --color -v --retry-on-error "${target}" --docker "${image}" diff --git a/test/utils/shippable/freebsd.sh b/test/utils/shippable/freebsd.sh index ded7ca1f582..5af7eab052b 100755 --- a/test/utils/shippable/freebsd.sh +++ b/test/utils/shippable/freebsd.sh @@ -9,4 +9,4 @@ platform="${args[0]}" version="${args[1]}" target="posix/ci/" -ansible-test integration --color -v --retry-on-error "${target}" --remote "${platform}/${version}" --exclude "posix/ci/cloud/" "${COVERAGE}" +ansible-test integration --color -v --retry-on-error "${target}" --remote "${platform}/${version}" --exclude "posix/ci/cloud/" diff --git a/test/utils/shippable/linux.sh b/test/utils/shippable/linux.sh index 9375e0699ee..1d98735c7e9 100755 --- a/test/utils/shippable/linux.sh +++ b/test/utils/shippable/linux.sh @@ -8,4 +8,4 @@ IFS='/:' read -ra args <<< "${TEST}" image="ansible/ansible:${args[1]}" target="posix/ci/group${args[2]}/" -ansible-test integration --color -v --retry-on-error "${target}" --docker "${image}" "${COVERAGE}" +ansible-test integration --color -v --retry-on-error "${target}" --docker "${image}" diff --git a/test/utils/shippable/network.sh b/test/utils/shippable/network.sh index 41fb6cbe6a9..57892bc4b3f 100755 --- a/test/utils/shippable/network.sh +++ b/test/utils/shippable/network.sh @@ -12,7 +12,7 @@ if [ -s /tmp/network.txt ]; then echo "Running network integration tests for multiple platforms concurrently." - ansible-test network-integration --color -v --retry-on-error "${target}" --requirements "${COVERAGE}" \ + ansible-test network-integration --color -v --retry-on-error "${target}" --requirements \ --platform vyos/1.1.0 \ --platform ios/csr1000v \ @@ -20,6 +20,6 @@ else echo "No changes requiring integration tests specific to networking were detected." echo "Running network integration tests for a single platform only." - ansible-test network-integration --color -v --retry-on-error "${target}" --requirements "${COVERAGE}" \ + ansible-test network-integration --color -v --retry-on-error "${target}" --requirements \ --platform vyos/1.1.0 fi diff --git a/test/utils/shippable/osx.sh b/test/utils/shippable/osx.sh index abdc3db6e75..5e6c18c91f7 100755 --- a/test/utils/shippable/osx.sh +++ b/test/utils/shippable/osx.sh @@ -9,5 +9,4 @@ platform="${args[0]}" version="${args[1]}" target="posix/ci/" -ansible-test integration --color -v --retry-on-error "${target}" --remote "${platform}/${version}" --remote-terminate success --exclude "posix/ci/cloud/" \ - "${COVERAGE}" +ansible-test integration --color -v --retry-on-error "${target}" --remote "${platform}/${version}" --remote-terminate success --exclude "posix/ci/cloud/" diff --git a/test/utils/shippable/other.sh b/test/utils/shippable/other.sh index 3ca5b6a53ca..3af08119135 100755 --- a/test/utils/shippable/other.sh +++ b/test/utils/shippable/other.sh @@ -10,8 +10,8 @@ retry.py pip install tox --disable-pip-version-check echo '{"verified": false, "results": []}' > test/results/bot/ansible-test-failure.json -ansible-test compile --failure-ok --color -v --junit --requirements --coverage -ansible-test sanity --failure-ok --color -v --junit --tox --skip-test ansible-doc --python 3.5 --coverage +ansible-test compile --failure-ok --color -v --junit --requirements +ansible-test sanity --failure-ok --color -v --junit --tox --skip-test ansible-doc --python 3.5 ansible-test sanity --failure-ok --color -v --junit --tox --test ansible-doc --coverage rm test/results/bot/ansible-test-failure.json diff --git a/test/utils/shippable/shippable.sh b/test/utils/shippable/shippable.sh index 516c2dc8812..4dde3766dc1 100755 --- a/test/utils/shippable/shippable.sh +++ b/test/utils/shippable/shippable.sh @@ -23,12 +23,6 @@ pip list --disable-pip-version-check export PATH="test/runner:${PATH}" export PYTHONIOENCODING='utf-8' -export COVERAGE="${COVERAGE:-}" - -# run integration coverage if 'ci_coverage' is in the commit message or the COVERAGE var is non-empty -if [[ "${COMMIT_MESSAGE}" =~ ci_coverage ]] || [ -n "${COVERAGE}" ]; then - export COVERAGE="--coverage" -fi # remove empty core/extras module directories from PRs created prior to the repo-merge find lib/ansible/modules -type d -empty -print -delete diff --git a/test/utils/shippable/windows.sh b/test/utils/shippable/windows.sh index 0c7a0dd8ccb..7ac724c8ce0 100755 --- a/test/utils/shippable/windows.sh +++ b/test/utils/shippable/windows.sh @@ -22,7 +22,7 @@ if [ -s /tmp/windows.txt ]; then target="windows/ci/" - ansible-test windows-integration --color -v --retry-on-error "${target}" --requirements "${COVERAGE}" \ + ansible-test windows-integration --color -v --retry-on-error "${target}" --requirements \ --windows 2008-SP2 \ --windows 2008-R2_SP1 \ --windows 2012-RTM \ @@ -34,6 +34,6 @@ else target="windows/ci/group${job}/" - ansible-test windows-integration --color -v --retry-on-error "${target}" --requirements "${COVERAGE}" \ + ansible-test windows-integration --color -v --retry-on-error "${target}" --requirements \ --windows 2012-R2_RTM fi