From b15e1b743f217ee50ad35ae2495c693037b2821e Mon Sep 17 00:00:00 2001 From: Alberto Murillo Date: Wed, 30 Nov 2016 22:10:49 -0600 Subject: [PATCH] Fix fetching files with scp (#18673) Commit ec2521f intended to fix the scp command to fetch files from a remote machine but it has src and dest swapped. This change correctly treats src as the location in the remote machine and dest as the location in the local machine. Signed-off-by: Alberto Murillo Silva (cherry picked from commit 7542dae26baa0d74dbb097a1f7c4b730375e8b4d) --- lib/ansible/plugins/connection/ssh.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ansible/plugins/connection/ssh.py b/lib/ansible/plugins/connection/ssh.py index 80a9fccb550..9eced8120b1 100644 --- a/lib/ansible/plugins/connection/ssh.py +++ b/lib/ansible/plugins/connection/ssh.py @@ -629,7 +629,7 @@ class Connection(ConnectionBase): in_data = u"{0} {1} {2}\n".format(sftp_action, pipes.quote(in_path), pipes.quote(out_path)) elif method == 'scp': if sftp_action == 'get': - cmd = self._build_command('scp', u'{0}:{1}'.format(host, pipes.quote(out_path)), in_path) + cmd = self._build_command('scp', u'{0}:{1}'.format(host, pipes.quote(in_path)), out_path) else: cmd = self._build_command('scp', in_path, u'{0}:{1}'.format(host, pipes.quote(out_path))) in_data = None