cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Route53 fix - forcing zone_in, record_in to lower case

Browse source 
It turns out the Route53 API cares if the zone and record specified in the playbook are lower case or not when deleting a record. If you use a variable to name your servers and care about case, using that same proper case name will cause Route53 DNS delete requests to fail.

The change requested adds .lower() to the module.params.get for both zone and record when used in the underlying code.

Both zone and record are mandatory variables, and as such a more complicated implementation is not needed, as they must always be specified when using this module see lines 169 and 170 for the required state).

If you use lowercase names (or don't use a name variable and share it between a tag and DNS entries) then you will never see this issue.

Tested/Confirmed as an issue in Ansible 1.6.6 and above.
This commit is contained in:
Phillip Holmes 2014-09-29 16:20:25 -05:00
parent db5668b84c
commit b3e84f2dd4
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
cloud/route53.py
View file

@ -178,9 +178,9 @@ def main():
module = AnsibleModule(argument_spec=argument_spec)
command_in = module.params.get('command')
zone_in = module.params.get('zone')
zone_in = module.params.get('zone').tolower
ttl_in = module.params.get('ttl')
record_in = module.params.get('record')
record_in = module.params.get('record').tolower
type_in = module.params.get('type')
value_in = module.params.get('value')
retry_interval_in = module.params.get('retry_interval')