From b4d75f41f56d1b06ca20040bf516ac4b5a598b65 Mon Sep 17 00:00:00 2001 From: Peter Sprygada Date: Thu, 26 Jan 2017 13:59:57 -0500 Subject: [PATCH] one more bug fix for ansible-connection (#20707) The connection instance will now return a meaningful error if the connection property returns False --- bin/ansible-connection | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/bin/ansible-connection b/bin/ansible-connection index c1984785706..5605c1a3888 100755 --- a/bin/ansible-connection +++ b/bin/ansible-connection @@ -122,7 +122,7 @@ class Server(): self.conn = connection_loader.get(play_context.connection, play_context, sys.stdin) self.conn._connect() if not self.conn.connected: - raise AnsibleConnectionFailure(err) + raise AnsibleConnectionFailure('unable to connect to remote host') self.socket = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) self.socket.bind(path) @@ -283,8 +283,6 @@ def main(): if pid == 0: try: server = Server(sf_path, pc) - except AnsibleConnectionFailure as exc: - log(str(exc), pc.remote_addr) except Exception as exc: log(traceback.format_exc(), pc.remote_addr) fcntl.lockf(lock_fd, fcntl.LOCK_UN)