cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Warn when transforming constructed groups (#60912)

Browse source 
* Warn when transforming constructed groups

The `keyed_groups` field has used sanitization since 2.6, but `groups` only started doing so in 2.8.
This adds a warning for the change in behavior.

* changelog

(cherry picked from commit 3247626ac7)
This commit is contained in:
Sloane Hertel 2019-08-20 11:32:02 -04:00 committed by Toshio Kuratomi
parent 0bc1285987
commit b77abd0491
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/60912-constructed-groups-option-sanitization.yaml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- constructed - Add a warning for the change in behavior in the sanitization of the groups option.

2
lib/ansible/plugins/inventory/__init__.py
View file

@ -372,7 +372,7 @@ class Constructable(object):
self.templar.set_available_variables(variables) self.templar.set_available_variables(variables)
for group_name in groups: for group_name in groups:
conditional = "{%% if %s %%} True {%% else %%} False {%% endif %%}" % groups[group_name] conditional = "{%% if %s %%} True {%% else %%} False {%% endif %%}" % groups[group_name]
group_name = self._sanitize_group_name(group_name) group_name = original_safe(group_name, force=True)
try: try:
result = boolean(self.templar.template(conditional)) result = boolean(self.templar.template(conditional))
except Exception as e: except Exception as e: