cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Do not remove local role file if given on the commandline

Browse source 
using this (for testing purpose) :
  $ ansible-galaxy install COPYING
  - error: the file downloaded was not a tar.gz
  - COPYING was NOT installed successfully.
  - you can use --ignore-errors to skip failed roles.

this result in COPYING being erased, which is surprising for the user.
This also prevent erasing requirements.yml if someone use the wrong flag.
This commit is contained in:
Michael Scherer 2014-09-13 12:27:47 +02:00
parent 267b3fb7b7
commit b9acaccc1d
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
bin/ansible-galaxy
View file

@ -787,7 +787,8 @@ def execute_install(args, options, parser):
if tmp_file: if tmp_file:
installed = install_role(role.get("name"), role.get("version"), tmp_file, options) installed = install_role(role.get("name"), role.get("version"), tmp_file, options)
# we're done with the temp file, clean it up # we're done with the temp file, clean it up
os.unlink(tmp_file) if tmp_file != role_src:
os.unlink(tmp_file)
# install dependencies, if we want them # install dependencies, if we want them
if not no_deps and installed: if not no_deps and installed:
if not role_data: if not role_data: