From c005ae3cd95bca0267f57e26abcbe0b8e128c8fd Mon Sep 17 00:00:00 2001 From: Brian Coca Date: Mon, 14 Nov 2016 17:40:48 -0500 Subject: [PATCH] removed package from squash actions fixes https://github.com/ansible/ansible-modules-core/issues/5595 --- CHANGELOG.md | 2 ++ lib/ansible/constants.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cbd99d17849..c5bcb122902 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,8 @@ Ansible Changes By Release * The version and release facts for OpenBSD hosts were reversed. This has been changed so that version has the numeric portion and release has the name of the release. +* removed 'package' from default squash actions as not all package managers support it and it creates errors when using loops, + any user can add back via config options if they don't use those package managers or othewise avoid the errors. ###Deprecations: * Specifying --tags (or --skip-tags) multiple times on the command line diff --git a/lib/ansible/constants.py b/lib/ansible/constants.py index 77b3242312b..6da17352c46 100644 --- a/lib/ansible/constants.py +++ b/lib/ansible/constants.py @@ -256,7 +256,7 @@ DEFAULT_BECOME_ASK_PASS = get_config(p, 'privilege_escalation', 'become_ask_pa # the module takes both, bad things could happen. # In the future we should probably generalize this even further # (mapping of param: squash field) -DEFAULT_SQUASH_ACTIONS = get_config(p, DEFAULTS, 'squash_actions', 'ANSIBLE_SQUASH_ACTIONS', "apk, apt, dnf, homebrew, package, pacman, pkgng, yum, zypper", value_type='list') +DEFAULT_SQUASH_ACTIONS = get_config(p, DEFAULTS, 'squash_actions', 'ANSIBLE_SQUASH_ACTIONS', "apk, apt, dnf, homebrew, pacman, pkgng, yum, zypper", value_type='list') # paths DEFAULT_ACTION_PLUGIN_PATH = get_config(p, DEFAULTS, 'action_plugins', 'ANSIBLE_ACTION_PLUGINS', '~/.ansible/plugins/action:/usr/share/ansible/plugins/action', value_type='pathlist') DEFAULT_CACHE_PLUGIN_PATH = get_config(p, DEFAULTS, 'cache_plugins', 'ANSIBLE_CACHE_PLUGINS', '~/.ansible/plugins/cache:/usr/share/ansible/plugins/cache', value_type='pathlist')