cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fixes #13763 Update connections _play_context on every iteration

Browse source 
If this isnt updated, the _connection is reused, and thus has an outdated _play_context
This results in outdated `success_key` and `prompt` causing issues if sudo is run in a loop
Refer to the issue #13763 for more debugging and details
This commit is contained in:
Karthik T 2016-01-11 16:30:52 +08:00
parent c3dd0213ef
commit c4cbeeffa8
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/ansible/executor/task_executor.py
View file

@ -365,6 +365,9 @@ class TaskExecutor:
if not self._connection or not getattr(self._connection, 'connected', False): if not self._connection or not getattr(self._connection, 'connected', False):
self._connection = self._get_connection(variables=variables, templar=templar) self._connection = self._get_connection(variables=variables, templar=templar)
self._connection.set_host_overrides(host=self._host) self._connection.set_host_overrides(host=self._host)
#If connection is reused, its _play_context is no longer valid and needs to be replaced
#This fixes issues with tasks running sudo in a loop and having the success_key incorrect in the second iteration
self._connection._play_context = self._play_context
self._handler = self._get_action_handler(connection=self._connection, templar=templar) self._handler = self._get_action_handler(connection=self._connection, templar=templar)