cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

check current version's existence (fire or cleanup)

Browse source 
* reserve current version when cleanup
* verify existence before fire a new version
* update doc of deploy_helper
This commit is contained in:
Robert Lu 2015-12-16 14:49:23 +08:00 committed by Matt Clay
parent 8ac9901481
commit c588be9bd8
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
lib/ansible/modules/extras/web_infrastructure/deploy_helper.py
View file

@ -110,7 +110,7 @@ options:
default: 5 default: 5
description: description:
- the number of old releases to keep when cleaning. Used in C(finalize) and C(clean). Any unfinished builds - the number of old releases to keep when cleaning. Used in C(finalize) and C(clean). Any unfinished builds
will be deleted first, so only correct releases will count. will be deleted first, so only correct releases will count. The current version will not count.
notes: notes:
- Facts are only returned for C(state=query) and C(state=present). If you use both, you should pass any overridden - Facts are only returned for C(state=query) and C(state=present). If you use both, you should pass any overridden
@ -318,6 +318,8 @@ class DeployHelper(object):
else: else:
changed = True changed = True
if not self.module.check_mode: if not self.module.check_mode:
if not os.path.lexists(source):
self.module.fail_json(msg="the symlink target %s doesn't exists" % source)
tmp_link_name = link_name + '.' + self.unfinished_filename tmp_link_name = link_name + '.' + self.unfinished_filename
if os.path.islink(tmp_link_name): if os.path.islink(tmp_link_name):
os.unlink(tmp_link_name) os.unlink(tmp_link_name)
@ -362,11 +364,15 @@ class DeployHelper(object):
return changed return changed
def cleanup(self, releases_path): def cleanup(self, releases_path, reserve_version):
changes = 0 changes = 0
if os.path.lexists(releases_path): if os.path.lexists(releases_path):
releases = [ f for f in os.listdir(releases_path) if os.path.isdir(os.path.join(releases_path,f)) ] releases = [ f for f in os.listdir(releases_path) if os.path.isdir(os.path.join(releases_path,f)) ]
try:
releases.remove(reserve_version)
except ValueError:
pass
if not self.module.check_mode: if not self.module.check_mode:
releases.sort( key=lambda x: os.path.getctime(os.path.join(releases_path,x)), reverse=True) releases.sort( key=lambda x: os.path.getctime(os.path.join(releases_path,x)), reverse=True)
@ -442,12 +448,12 @@ def main():
if deploy_helper.clean: if deploy_helper.clean:
changes += deploy_helper.remove_unfinished_link(facts['path']) changes += deploy_helper.remove_unfinished_link(facts['path'])
changes += deploy_helper.remove_unfinished_builds(facts['releases_path']) changes += deploy_helper.remove_unfinished_builds(facts['releases_path'])
changes += deploy_helper.cleanup(facts['releases_path']) changes += deploy_helper.cleanup(facts['releases_path'], facts['new_release'])
elif deploy_helper.state == 'clean': elif deploy_helper.state == 'clean':
changes += deploy_helper.remove_unfinished_link(facts['path']) changes += deploy_helper.remove_unfinished_link(facts['path'])
changes += deploy_helper.remove_unfinished_builds(facts['releases_path']) changes += deploy_helper.remove_unfinished_builds(facts['releases_path'])
changes += deploy_helper.cleanup(facts['releases_path']) changes += deploy_helper.cleanup(facts['releases_path'], facts['new_release'])
elif deploy_helper.state == 'absent': elif deploy_helper.state == 'absent':
# destroy the facts # destroy the facts