cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Reference correct variable and key for role expiry (#23397)

Browse source 
Previously, this module could throw the following error message:
    NameError: global name 'current_roles_attrs' is not defined

The referencing key should also match the name of the column, which is
rolvaliduntil, not rol_valid_until
This commit is contained in:
Feike Steenbergen 2017-05-09 15:03:22 +02:00 committed by John R Barker
parent a255cfd22a
commit c5adf08c40
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/ansible/modules/database/postgresql/postgresql_user.py
View file

@ -321,7 +321,7 @@ def user_alter(cursor, module, user, password, role_attr_flags, encrypted, expir
if current_role_attrs[PRIV_TO_AUTHID_COLUMN[role_attr_name]] != role_attr_value:
role_attr_flags_changing = True
expires_changing = (expires is not None and expires == current_roles_attrs['rol_valid_until'])
expires_changing = (expires is not None and expires == current_role_attrs['rolvaliduntil'])
if not pwchanging and not role_attr_flags_changing and not expires_changing:
return False