Remove empty setUp/tearDown/tearDownClass methods in test classes.
This commit is contained in:
parent
14f68e31ab
commit
c5d61953b1
14 changed files with 1 additions and 79 deletions
|
@ -32,12 +32,6 @@ from units.mock.path import mock_unfrackpath_noop
|
||||||
|
|
||||||
class TestPlayIterator(unittest.TestCase):
|
class TestPlayIterator(unittest.TestCase):
|
||||||
|
|
||||||
def setUp(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def tearDown(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def test_host_state(self):
|
def test_host_state(self):
|
||||||
hs = HostState(blocks=[x for x in range(0, 10)])
|
hs = HostState(blocks=[x for x in range(0, 10)])
|
||||||
hs.tasks_child_state = HostState(blocks=[0])
|
hs.tasks_child_state = HostState(blocks=[0])
|
||||||
|
|
|
@ -35,12 +35,6 @@ from units.mock.loader import DictDataLoader
|
||||||
|
|
||||||
class TestTaskExecutor(unittest.TestCase):
|
class TestTaskExecutor(unittest.TestCase):
|
||||||
|
|
||||||
def setUp(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def tearDown(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def test_task_executor_init(self):
|
def test_task_executor_init(self):
|
||||||
fake_loader = DictDataLoader({})
|
fake_loader = DictDataLoader({})
|
||||||
mock_host = MagicMock()
|
mock_host = MagicMock()
|
||||||
|
|
|
@ -56,16 +56,10 @@ class TestNetscalerNitroRequestModule(TestModule):
|
||||||
|
|
||||||
cls.MockException = MockException
|
cls.MockException = MockException
|
||||||
|
|
||||||
@classmethod
|
# This has code in a parent class
|
||||||
def tearDownClass(cls):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def setUp(self):
|
def setUp(self):
|
||||||
pass
|
pass
|
||||||
|
|
||||||
def tearDown(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def test_fail_on_conflicting_authentication_methods(self):
|
def test_fail_on_conflicting_authentication_methods(self):
|
||||||
args = copy.deepcopy(module_arguments)
|
args = copy.deepcopy(module_arguments)
|
||||||
args.update(dict(
|
args.update(dict(
|
||||||
|
|
|
@ -39,9 +39,6 @@ class TestDataLoader(unittest.TestCase):
|
||||||
def setUp(self):
|
def setUp(self):
|
||||||
self._loader = DataLoader()
|
self._loader = DataLoader()
|
||||||
|
|
||||||
def tearDown(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
@patch('os.path.exists')
|
@patch('os.path.exists')
|
||||||
def test__is_role(self, p_exists):
|
def test__is_role(self, p_exists):
|
||||||
p_exists.side_effect = lambda p: p == b'test_path/tasks/main.yml'
|
p_exists.side_effect = lambda p: p == b'test_path/tasks/main.yml'
|
||||||
|
|
|
@ -166,12 +166,6 @@ class TestHashParams(unittest.TestCase):
|
||||||
|
|
||||||
class TestRole(unittest.TestCase):
|
class TestRole(unittest.TestCase):
|
||||||
|
|
||||||
def setUp(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def tearDown(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
@patch('ansible.playbook.role.definition.unfrackpath', mock_unfrackpath_noop)
|
@patch('ansible.playbook.role.definition.unfrackpath', mock_unfrackpath_noop)
|
||||||
def test_load_role_with_tasks(self):
|
def test_load_role_with_tasks(self):
|
||||||
|
|
||||||
|
|
|
@ -29,12 +29,6 @@ from units.mock.loader import DictDataLoader
|
||||||
|
|
||||||
class TestPlaybook(unittest.TestCase):
|
class TestPlaybook(unittest.TestCase):
|
||||||
|
|
||||||
def setUp(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def tearDown(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def test_empty_playbook(self):
|
def test_empty_playbook(self):
|
||||||
fake_loader = DictDataLoader({})
|
fake_loader = DictDataLoader({})
|
||||||
p = Playbook(loader=fake_loader)
|
p = Playbook(loader=fake_loader)
|
||||||
|
|
|
@ -55,12 +55,6 @@ class TestINILookup(unittest.TestCase):
|
||||||
),
|
),
|
||||||
)
|
)
|
||||||
|
|
||||||
def setUp(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def tearDown(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def test_parse_parameters(self):
|
def test_parse_parameters(self):
|
||||||
for testcase in self.old_style_params_data:
|
for testcase in self.old_style_params_data:
|
||||||
# print(testcase)
|
# print(testcase)
|
||||||
|
|
|
@ -126,12 +126,6 @@ class LoggedOutMockLPass(MockLPass):
|
||||||
|
|
||||||
class TestLPass(unittest.TestCase):
|
class TestLPass(unittest.TestCase):
|
||||||
|
|
||||||
def setUp(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def tearDown(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def test_lastpass_cli_path(self):
|
def test_lastpass_cli_path(self):
|
||||||
lp = MockLPass(path='/dev/null')
|
lp = MockLPass(path='/dev/null')
|
||||||
self.assertEqual('/dev/null', lp.cli_path)
|
self.assertEqual('/dev/null', lp.cli_path)
|
||||||
|
|
|
@ -36,12 +36,6 @@ from ansible.plugins.strategy import StrategyBase
|
||||||
|
|
||||||
class TestStrategyBase(unittest.TestCase):
|
class TestStrategyBase(unittest.TestCase):
|
||||||
|
|
||||||
def setUp(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def tearDown(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def test_strategy_base_init(self):
|
def test_strategy_base_init(self):
|
||||||
queue_items = []
|
queue_items = []
|
||||||
|
|
||||||
|
|
|
@ -21,12 +21,6 @@ from units.mock.path import mock_unfrackpath_noop
|
||||||
|
|
||||||
class TestStrategyLinear(unittest.TestCase):
|
class TestStrategyLinear(unittest.TestCase):
|
||||||
|
|
||||||
def setUp(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def tearDown(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
@patch('ansible.playbook.role.definition.unfrackpath', mock_unfrackpath_noop)
|
@patch('ansible.playbook.role.definition.unfrackpath', mock_unfrackpath_noop)
|
||||||
def test_noop(self):
|
def test_noop(self):
|
||||||
fake_loader = DictDataLoader({
|
fake_loader = DictDataLoader({
|
||||||
|
|
|
@ -33,9 +33,6 @@ class TestPluginTerminalSLXOS(unittest.TestCase):
|
||||||
self._mock_connection = MagicMock()
|
self._mock_connection = MagicMock()
|
||||||
self._terminal = slxos.TerminalModule(self._mock_connection)
|
self._terminal = slxos.TerminalModule(self._mock_connection)
|
||||||
|
|
||||||
def tearDown(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def test_on_open_shell(self):
|
def test_on_open_shell(self):
|
||||||
""" Test on_open_shell
|
""" Test on_open_shell
|
||||||
"""
|
"""
|
||||||
|
|
|
@ -30,12 +30,6 @@ from ansible.plugins.loader import PluginLoader
|
||||||
|
|
||||||
class TestErrors(unittest.TestCase):
|
class TestErrors(unittest.TestCase):
|
||||||
|
|
||||||
def setUp(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def tearDown(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
@patch.object(PluginLoader, '_get_paths')
|
@patch.object(PluginLoader, '_get_paths')
|
||||||
def test_print_paths(self, mock_method):
|
def test_print_paths(self, mock_method):
|
||||||
mock_method.return_value = ['/path/one', '/path/two', '/path/three']
|
mock_method.return_value = ['/path/one', '/path/two', '/path/three']
|
||||||
|
|
|
@ -64,12 +64,6 @@ class TestVariableUtils(unittest.TestCase):
|
||||||
),
|
),
|
||||||
)
|
)
|
||||||
|
|
||||||
def setUp(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def tearDown(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def test_merge_hash(self):
|
def test_merge_hash(self):
|
||||||
for test in self.test_merge_data:
|
for test in self.test_merge_data:
|
||||||
self.assertEqual(merge_hash(test['a'], test['b']), test['result'])
|
self.assertEqual(merge_hash(test['a'], test['b']), test['result'])
|
||||||
|
|
|
@ -36,12 +36,6 @@ from ansible.vars.manager import VariableManager
|
||||||
|
|
||||||
class TestVariableManager(unittest.TestCase):
|
class TestVariableManager(unittest.TestCase):
|
||||||
|
|
||||||
def setUp(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def tearDown(self):
|
|
||||||
pass
|
|
||||||
|
|
||||||
def test_basic_manager(self):
|
def test_basic_manager(self):
|
||||||
fake_loader = DictDataLoader({})
|
fake_loader = DictDataLoader({})
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue