From c73f9d04921841f9e6436ba76ae8457f26748032 Mon Sep 17 00:00:00 2001 From: jctanner Date: Fri, 19 Aug 2016 14:59:10 -0400 Subject: [PATCH] git: add a umask parameter (#4473) Sources #10504 Fixes #10279 --- lib/ansible/modules/source_control/git.py | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/lib/ansible/modules/source_control/git.py b/lib/ansible/modules/source_control/git.py index 1687ee4dc22..c8757023398 100644 --- a/lib/ansible/modules/source_control/git.py +++ b/lib/ansible/modules/source_control/git.py @@ -140,6 +140,13 @@ options: description: - if C(yes), repository will be created as a bare repo, otherwise it will be a standard repo with a workspace. + umask: + required: false + default: null + version_added: "2.2" + description: + - The umask to set before doing any checkouts, or any other + repository maintenance. recursive: required: false @@ -209,6 +216,8 @@ import re import tempfile from distutils.version import LooseVersion +from ansible.module_utils.six import string_types + def head_splitter(headfile, remote, module=None, fail_on_error=False): '''Extract the head reference''' # https://github.com/ansible/ansible-modules-core/pull/907 @@ -813,6 +822,7 @@ def main(): bare=dict(default='no', type='bool'), recursive=dict(default='yes', type='bool'), track_submodules=dict(default='no', type='bool'), + umask=dict(default=None, type='raw'), ), supports_check_mode=True ) @@ -832,9 +842,21 @@ def main(): git_path = module.params['executable'] or module.get_bin_path('git', True) key_file = module.params['key_file'] ssh_opts = module.params['ssh_opts'] + umask = module.params['umask'] result = dict( warnings=list() ) + # evaluate and set the umask before doing anything else + if umask != None: + if not isinstance(umask, string_types): + module.fail_json(msg="umask must be defined as a quoted octal integer") + try: + umask = int(umask, 8) + except: + module.fail_json(msg="umask must be an octal integer", + details=str(sys.exc_info()[1])) + os.umask(umask) + # Certain features such as depth require a file:/// protocol for path based urls # so force a protocal here ... if repo.startswith('/'):