cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Performance improvement using in-operator for hash lookups

Browse source 
Just a small cleanup for the existing occurrences.

Using the in-operator for hash lookups is faster than using .has_key()
http://stackoverflow.com/questions/1323410/has-key-or-in
This commit is contained in:
Dag Wieers 2016-11-17 16:02:09 +01:00 committed by Matt Clay
parent a417a4f4b3
commit c8a700834c
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/ansible/modules/extras/system/crypttab.py
View file

@ -312,7 +312,7 @@ class Options(dict):
def add(self, opts_string):
changed = False
for k, v in Options(opts_string).items():
if self.has_key(k):
if k in self:
if self[k] != v:
changed = True
else:
@ -323,7 +323,7 @@ class Options(dict):
def remove(self, opts_string):
changed = False
for k in Options(opts_string):
if self.has_key(k):
if k in self:
del self[k]
changed = True
return changed, 'removed options'
@ -341,7 +341,7 @@ class Options(dict):
return iter(self.itemlist)
def __setitem__(self, key, value):
if not self.has_key(key):
if key not in self:
self.itemlist.append(key)
super(Options, self).__setitem__(key, value)