From ca8bf6ab4c26530df4d841c9bb43f37dd03da44f Mon Sep 17 00:00:00 2001 From: TheSameCH Date: Thu, 5 May 2016 04:09:55 +0200 Subject: [PATCH] remove checking of stderr for insserv (#1846) stderr of insserv can also contain warnings which can be ignored. checking rc only is more accurate. fixes #1502 --- lib/ansible/modules/system/service.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ansible/modules/system/service.py b/lib/ansible/modules/system/service.py index b0e39993a9f..ff5692c5317 100644 --- a/lib/ansible/modules/system/service.py +++ b/lib/ansible/modules/system/service.py @@ -826,12 +826,12 @@ class LinuxService(Service): if self.enable: (rc, out, err) = self.execute_command("%s %s" % (self.enable_cmd, self.name)) - if (rc != 0) or (err != ''): + if (rc != 0): self.module.fail_json(msg=("Failed to install service. rc: %s, out: %s, err: %s" % (rc, out, err))) return (rc, out, err) else: (rc, out, err) = self.execute_command("%s -r %s" % (self.enable_cmd, self.name)) - if (rc != 0) or (err != ''): + if (rc != 0): self.module.fail_json(msg=("Failed to remove service. rc: %s, out: %s, err: %s" % (rc, out, err))) return (rc, out, err)