ignore password flags in become conflict check

since all the --ask pass options end up triggering the same code
and are functionally equivalent, ignore them when it comes to checking
privilege escalation conflicts. This allows using -K when --become-method=su
and so on.
This commit is contained in:
Brian Coca 2015-12-01 08:15:53 -08:00
parent 204e27ca66
commit ca8c6e8e1c

View file

@ -191,12 +191,9 @@ class CLI(object):
if runas_opts: if runas_opts:
# Check for privilege escalation conflicts # Check for privilege escalation conflicts
if (op.su or op.su_user or op.ask_su_pass) and \ if (op.su or op.su_user) and (op.sudo or op.sudo_user) or \
(op.sudo or op.sudo_user or op.ask_sudo_pass) or \ (op.su or op.su_user) and (op.become or op.become_user) or \
(op.su or op.su_user or op.ask_su_pass) and \ (op.sudo or op.sudo_user) and (op.become or op.become_user):
(op.become or op.become_user or op.become_ask_pass) or \
(op.sudo or op.sudo_user or op.ask_sudo_pass) and \
(op.become or op.become_user or op.become_ask_pass):
self.parser.error("Sudo arguments ('--sudo', '--sudo-user', and '--ask-sudo-pass') " self.parser.error("Sudo arguments ('--sudo', '--sudo-user', and '--ask-sudo-pass') "
"and su arguments ('-su', '--su-user', and '--ask-su-pass') " "and su arguments ('-su', '--su-user', and '--ask-su-pass') "