better handling of checkmode for solaris

fixes #2296
This commit is contained in:
Brian Coca 2015-10-19 16:38:15 -04:00
parent f4ed4b37a9
commit ccbcff8c8e

View file

@ -1352,11 +1352,10 @@ class SunOS(User):
cmd.append('-s')
cmd.append(self.shell)
if self.module.check_mode:
return (0, '', '')
else:
# modify the user if cmd will do anything
if cmd_len != len(cmd):
(rc, out, err) = (0, '', '')
if not self.module.check_mode:
cmd.append(self.name)
(rc, out, err) = self.execute_command(cmd)
if rc is not None and rc != 0:
@ -1366,6 +1365,8 @@ class SunOS(User):
# we have to set the password by editing the /etc/shadow file
if self.update_password == 'always' and self.password is not None and info[1] != self.password:
(rc, out, err) = (0, '', '')
if not self.module.check_mode:
try:
lines = []
for line in open(self.SHADOWFILE, 'rb').readlines():