From cf3f1b9d3f9b2bb3de769e9a9fdd3ed7df2e59a0 Mon Sep 17 00:00:00 2001 From: Mark Chappell Date: Mon, 9 Dec 2019 10:16:02 +0100 Subject: [PATCH] iam: Make 'name' required to match the documentation (#65557) With the exception of deleting Users and Roles (where we'd do nothing and exit) not passing a name would trigger a boto exception. --- changelogs/fragments/65557-iam-make-name-required.yml | 2 ++ lib/ansible/modules/cloud/amazon/iam.py | 3 ++- test/sanity/ignore.txt | 1 - 3 files changed, 4 insertions(+), 2 deletions(-) create mode 100644 changelogs/fragments/65557-iam-make-name-required.yml diff --git a/changelogs/fragments/65557-iam-make-name-required.yml b/changelogs/fragments/65557-iam-make-name-required.yml new file mode 100644 index 00000000000..81e2602e396 --- /dev/null +++ b/changelogs/fragments/65557-iam-make-name-required.yml @@ -0,0 +1,2 @@ +minor_changes: +- iam - make `name` a required field. diff --git a/lib/ansible/modules/cloud/amazon/iam.py b/lib/ansible/modules/cloud/amazon/iam.py index 9f375046514..7ff7f74be1f 100644 --- a/lib/ansible/modules/cloud/amazon/iam.py +++ b/lib/ansible/modules/cloud/amazon/iam.py @@ -24,6 +24,7 @@ options: - Type of IAM resource. choices: ["user", "group", "role"] type: str + required: true name: description: - Name of IAM resource to create or identify. @@ -632,7 +633,7 @@ def main(): 'Active', 'Inactive', 'Create', 'Remove']), access_key_ids=dict(type='list', default=None, required=False), key_count=dict(type='int', default=1, required=False), - name=dict(default=None, required=False), + name=dict(required=True), trust_policy_filepath=dict(default=None, required=False), trust_policy=dict(type='dict', default=None, required=False), new_name=dict(default=None, required=False), diff --git a/test/sanity/ignore.txt b/test/sanity/ignore.txt index a6f811f71b5..2ec00125895 100644 --- a/test/sanity/ignore.txt +++ b/test/sanity/ignore.txt @@ -492,7 +492,6 @@ lib/ansible/modules/cloud/alicloud/ali_instance.py validate-modules:parameter-ty lib/ansible/modules/cloud/alicloud/ali_instance_info.py validate-modules:doc-missing-type lib/ansible/modules/cloud/alicloud/ali_instance_info.py validate-modules:doc-required-mismatch lib/ansible/modules/cloud/alicloud/ali_instance_info.py validate-modules:parameter-type-not-in-doc -lib/ansible/modules/cloud/amazon/iam.py validate-modules:doc-required-mismatch lib/ansible/modules/cloud/amazon/iam_cert.py validate-modules:doc-required-mismatch lib/ansible/modules/cloud/amazon/iam_policy.py validate-modules:doc-required-mismatch lib/ansible/modules/cloud/atomic/atomic_container.py validate-modules:doc-missing-type