cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Bugfix: Creating two IPs in single run of netbox_ip_address (#56550)

Browse source 
* Found bug, fixed by moving the serialization of objects out of try while creating objects

* Added changelog to document fix
This commit is contained in:
Mikhail Yohman 2019-06-12 08:45:20 -06:00 • committed by Sloane Hertel
parent a50b3d7695
commit d07d394779
2 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
changelogs/fragments/netbox_ip_address-fix-duplicate-ip.yaml Normal file
View file

@ -0,0 +1,6 @@
---
bugfixes:
- >
netbox_ip_address - Fixed issue where it would create duplicate IP addresses when trying to serialize the IP address object
which doesn't have the ``.serialize()`` method. This should also prevent future duplicate objects being created if they don't
have the ``.serialize()`` method as well.

5
lib/ansible/module_utils/net_tools/netbox/netbox_utils.py
View file

@ -197,10 +197,11 @@ def create_netbox_object(nb_endpoint, data, check_mode):
if check_mode: if check_mode:
serialized_nb_obj = data serialized_nb_obj = data
else: else:
nb_obj = nb_endpoint.create(data)
try: try:
serialized_nb_obj = nb_endpoint.create(data).serialize() serialized_nb_obj = nb_obj.serialize()
except AttributeError: except AttributeError:
serialized_nb_obj = nb_endpoint.create(data) serialized_nb_obj = nb_obj
diff = _build_diff(before={"state": "absent"}, after={"state": "present"}) diff = _build_diff(before={"state": "absent"}, after={"state": "present"})
return serialized_nb_obj, diff return serialized_nb_obj, diff