cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Make sure warnings are printed during fact gathering ()

Browse source
This commit is contained in:
Jordan Borean 2020-01-10 06:16:20 +10:00 • committed by GitHub
parent a3d67edfca
commit d3427bb860
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 2 deletions
changelogs/fragments
gather_facts-warnings.yaml
lib/ansible/plugins/action
gather_facts.py

2
changelogs/fragments/gather_facts-warnings.yaml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- fact gathering - Display warnings and deprecation messages that are created during the fact gathering phase

13
lib/ansible/plugins/action/gather_facts.py
View file

@ -45,6 +45,15 @@ class ActionModule(ActionBase):
return mod_args
def _combine_task_result(self, result, task_result):
filtered_res = {
'ansible_facts': task_result.get('ansible_facts', {}),
'warnings': task_result.get('warnings', []),
'deprecations': task_result.get('deprecations', []),
}
return combine_vars(result, filtered_res)
def run(self, tmp=None, task_vars=None):
self._supports_check_mode = True
@ -73,7 +82,7 @@ class ActionModule(ActionBase):
elif res.get('skipped', False):
skipped[fact_module] = res
else:
result = combine_vars(result, {'ansible_facts': res.get('ansible_facts', {})})
result = self._combine_task_result(result, res)
self._remove_tmp_path(self._connection._shell.tmpdir)
else:
@ -95,7 +104,7 @@ class ActionModule(ActionBase):
elif res.get('skipped', False):
skipped[module] = res
else:
result = combine_vars(result, {'ansible_facts': res.get('ansible_facts', {})})
result = self._combine_task_result(result, res)
del jobs[module]
break
else: