cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

return failed if a package couldn't be installed

Browse source 
For some reason, on my test mandriva, urpmi --force return 0
even when it cannot install a rpm. So we have to explicitely check
if the package was properly installed with a loop
This commit is contained in:
Michael Scherer 2013-11-18 00:22:54 +01:00
parent b7971a426c
commit d66027ba7a
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
library/packaging/urpmi
View file

@ -158,7 +158,14 @@ def install_packages(module, pkgspec, force=True, no_suggests=True):
cmd = ("%s --auto %s --quiet %s %s > /dev/null" % (URPMI_PATH, force_yes, no_suggests_yes, packages)) cmd = ("%s --auto %s --quiet %s %s > /dev/null" % (URPMI_PATH, force_yes, no_suggests_yes, packages))
rc, out, err = module.run_command(cmd) rc, out, err = module.run_command(cmd)
if rc:
installed = True
for packages in pkgspec:
if not query_package_provides(module, package):
installed = False
# urpmi always have 0 for exit code if --force is used
if rc or not installed:
module.fail_json(msg="'urpmi %s' failed: %s" % (packages, err)) module.fail_json(msg="'urpmi %s' failed: %s" % (packages, err))
else: else:
module.exit_json(changed=True, msg="%s present(s)" % packages) module.exit_json(changed=True, msg="%s present(s)" % packages)