cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

svr4pkg: assume command worked only on known-to-be-good returncodes

Browse source
This commit is contained in:
Dagobert Michelsen 2015-05-27 13:35:34 +02:00 committed by Matt Clay
parent 1780512ef5
commit d744777425
1 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
lib/ansible/modules/extras/packaging/os/svr4pkg.py
View file

@ -209,15 +209,25 @@ def main():
(rc, out, err) = package_uninstall(module, name, src, category) (rc, out, err) = package_uninstall(module, name, src, category)
out = out[:75] out = out[:75]
# Success, Warning, Interruption, Reboot all, Reboot this return codes # Returncodes as per pkgadd(1m)
# 0 Successful completion
# 1 Fatal error.
# 2 Warning.
# 3 Interruption.
# 4 Administration.
# 5 Administration. Interaction is required. Do not use pkgadd -n.
# 10 Reboot after installation of all packages.
# 20 Reboot after installation of this package.
# 99 (observed) pkgadd: ERROR: could not process datastream from </tmp/pkgutil.pkg>
if rc in (0, 2, 3, 10, 20): if rc in (0, 2, 3, 10, 20):
result['changed'] = True result['changed'] = True
# no install nor uninstall, or failed # no install nor uninstall, or failed
else: else:
result['changed'] = False result['changed'] = False
# Fatal error, Administration, Administration Interaction return codes # Only return failed=False when the returncode is known to be good as there may be more
if rc in (1, 4 , 5): # undocumented failure return codes
if rc not in (0, 2, 10, 20):
result['failed'] = True result['failed'] = True
else: else:
result['failed'] = False result['failed'] = False