cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Document and warn when max_fail and free are used (#72616)

Browse source 
Fixes #16666
This commit is contained in:
Brian Coca 2020-11-17 10:11:15 -05:00 committed by GitHub
parent 13bc35e13c
commit d8baf4d38d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/max_fail_free.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- Updated docs and added warning on max_fail_percentage and free strategy usage. fixes issue 16666.

2
lib/ansible/keyword_desc.yml
View file

@ -46,7 +46,7 @@ loop_control: |
.. seealso:: :ref:`loop_control` .. seealso:: :ref:`loop_control`
max_fail_percentage: can be used to abort the run after a given percentage of hosts in the current batch has failed. max_fail_percentage: can be used to abort the run after a given percentage of hosts in the current batch has failed. This only wokrs on linear or linear derived strategies.
module_defaults: Specifies default parameter values for modules. module_defaults: Specifies default parameter values for modules.
name: "Identifier. Can be used for documentation, or in tasks/handlers." name: "Identifier. Can be used for documentation, or in tasks/handlers."
no_log: Boolean that controls information disclosure. no_log: Boolean that controls information disclosure.

3
lib/ansible/plugins/strategy/free.py
View file

@ -92,6 +92,9 @@ class StrategyModule(StrategyBase):
self._set_hosts_cache(iterator._play) self._set_hosts_cache(iterator._play)
if iterator._play.max_fail_percentage is not None:
display.warning("Using max_fail_percentage with the free strategy is not supported, as tasks are executed independently on each host")
work_to_do = True work_to_do = True
while work_to_do and not self._tqm._terminated: while work_to_do and not self._tqm._terminated: