From d9f5be8d0d8a036aaa89056536f58b4a2e3c86b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Ne=C4=8Das?= Date: Tue, 5 Nov 2019 14:22:17 +0100 Subject: [PATCH] Ovirt host network dict correct (#64437) * ovirt_host_network: correct comparing of two dicts * update mode_number for 4th option --- lib/ansible/modules/cloud/ovirt/ovirt_host_network.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_host_network.py b/lib/ansible/modules/cloud/ovirt/ovirt_host_network.py index b051e3079d5..e6d741adbd4 100644 --- a/lib/ansible/modules/cloud/ovirt/ovirt_host_network.py +++ b/lib/ansible/modules/cloud/ovirt/ovirt_host_network.py @@ -214,7 +214,7 @@ def get_bond_options(mode, usr_opts): None, 'Dynamic link aggregation (802.3ad)', ] - if (not 0 < mode_number <= len(modes) - 1): + if (not 0 < mode_number <= len(modes)): return None return modes[mode_number - 1] @@ -245,7 +245,9 @@ def get_bond_options(mode, usr_opts): class HostNetworksModule(BaseModule): def __compare_options(self, new_options, old_options): - return sorted(get_dict_of_struct(opt) for opt in new_options) != sorted(get_dict_of_struct(opt) for opt in old_options) + return sorted((get_dict_of_struct(opt) for opt in new_options), + key=lambda x: x["name"]) != sorted((get_dict_of_struct(opt) for opt in old_options), + key=lambda x: x["name"]) def build_entity(self): return otypes.Host()