cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix nxos_ospf_vrf module auto-cost idempotency and module check mode (#47190)

Browse source 
* fixing idempotency and check mode

* modified to avoid repetitive code
This commit is contained in:
Dan 2018-10-23 09:58:24 +01:00 committed by Trishna Guha
parent 6629f153d2
commit dcb35c4270
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/ansible/modules/network/nxos/nxos_ospf_vrf.py
View file

@ -204,7 +204,7 @@ def get_existing(module, args):
elif 'auto' in line: elif 'auto' in line:
cost = re.search(r'auto-cost reference-bandwidth (\d+) (\S+)', line).group(1) cost = re.search(r'auto-cost reference-bandwidth (\d+) (\S+)', line).group(1)
if 'Gbps' in line: if 'Gbps' in line:
cost *= 1000 cost = int(cost) * 1000
existing['auto_cost'] = str(cost) existing['auto_cost'] = str(cost)
elif 'timers throttle lsa' in line: elif 'timers throttle lsa' in line:
tmp = re.search(r'timers throttle lsa (\S+) (\S+) (\S+)', line) tmp = re.search(r'timers throttle lsa (\S+) (\S+) (\S+)', line)
@ -377,7 +377,7 @@ def main():
warnings = list() warnings = list()
check_args(module, warnings) check_args(module, warnings)
result = dict(changed=False, warnings=warnings) result = dict(changed=False, commands=[], warnings=warnings)
state = module.params['state'] state = module.params['state']
args = PARAM_TO_COMMAND_KEYMAP.keys() args = PARAM_TO_COMMAND_KEYMAP.keys()
@ -407,12 +407,10 @@ def main():
if candidate: if candidate:
candidate = candidate.items_text() candidate = candidate.items_text()
result['commands'] = candidate
if not module.check_mode:
load_config(module, candidate) load_config(module, candidate)
result['changed'] = True result['changed'] = True
result['commands'] = candidate
else:
result['commands'] = []
module.exit_json(**result) module.exit_json(**result)