cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fixes bugs in the bigip_software modules (#45577)

Browse source 
This patch makes hotfix code work, where before, only base images
were working
This commit is contained in:
Tim Rupp 2018-09-12 15:56:43 -04:00 committed by GitHub
parent e35c4be1c1
commit e266a24263
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/ansible/modules/network/f5/bigip_software_image.py
View file

@ -285,7 +285,7 @@ class ModuleManager(object):
return self.create() return self.create()
def exists(self): def exists(self):
if self.image_exists() or self.image_exists(): if self.image_exists() or self.hotfix_exists():
return True return True
return False return False
@ -408,7 +408,7 @@ class ModuleManager(object):
except ValueError as ex: except ValueError as ex:
raise F5ModuleError(str(ex)) raise F5ModuleError(str(ex))
if 'code' in response and response['code'] == 400: if 'code' in response and response['code'] in [400, 404]:
if 'message' in response: if 'message' in response:
raise F5ModuleError(response['message']) raise F5ModuleError(response['message'])
else: else:
@ -438,7 +438,7 @@ class ModuleManager(object):
response = self.client.api.delete(uri) response = self.client.api.delete(uri)
if response.status == 200: if response.status == 200:
return True return True
if 'code' in response and response['code'] == 400: if 'code' in response and response['code'] in [400, 404]:
if 'message' in response: if 'message' in response:
raise F5ModuleError(response['message']) raise F5ModuleError(response['message'])
else: else:

9
lib/ansible/modules/network/f5/bigip_software_install.py
View file

@ -188,7 +188,7 @@ class ModuleParameters(Parameters):
image = self.read_image_from_device(type='image') image = self.read_image_from_device(type='image')
if image: if image:
return image return image
image = self.read_hotfix_from_device(type='hotfix') image = self.read_image_from_device(type='hotfix')
if image: if image:
return image return image
return None return None
@ -206,11 +206,8 @@ class ModuleParameters(Parameters):
except ValueError: except ValueError:
return None return None
if 'code' in response and response['code'] == 400: if 'code' in response and response['code'] in [400, 404]:
if 'message' in response: return None
return None
else:
return None
return response return response