cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

pkgin: change install/remove to not use return code of pkgin

Browse source 
pkgin always returns 0 so can't be used to tell if the install or remove
worked.  Instead this just queries the installed packages after
performing an operation.
This commit is contained in:
Shaun Zinck 2013-01-24 19:58:31 -06:00
parent 4a9201ad65
commit e34eaa423d
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
library/pkgin
View file

@ -82,7 +82,7 @@ def remove_packages(module, packages):
rc = os.system("%s -y remove %s" % (PKGIN_PATH, package))
if rc != 0:
if query_package(module, package):
module.fail_json(msg="failed to remove %s" % (package))
remove_c += 1
@ -104,7 +104,7 @@ def install_packages(module, packages):
rc = os.system("%s -y install %s" % (PKGIN_PATH, package))
if rc != 0:
if not query_package(module, package):
module.fail_json(msg="failed to install %s" % (package))
install_c += 1